From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 27AC33FDAC6; Thu, 30 Mar 2023 20:43:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 27AC33FDAC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1680198202; bh=29E1IczCHnNFSyDqPmJ906XEpJvVUSgMOLjkMlMO2G4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t8IfCIkFEJ/QMWf82dFPsZ3Fe3fj0DfLcSE0JYHNslbof8rOLsiPtoou238vOZ8Q6 bvbbGZ6bPQOrMGaDupbP2ZWKdcaBfJ6X2VZQlTppVAXopNOOK+2SSs0pUkrMbbkUAc rIcfrxgqNMJdL1KrkWlYRkYXZXlmERPjppEuJ1mI= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0A303215DEA for ; Thu, 30 Mar 2023 20:43:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A303215DEA Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1phwIw-00GNg1-QP; Thu, 30 Mar 2023 20:43:19 +0300 Date: Thu, 30 Mar 2023 17:36:03 +0000 To: Maksim Kokryashkin Message-ID: References: <20230316161720.78669-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230316161720.78669-1-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9381BDEF7E8905223B336BEBABBA06DCCB6C010CA664C617B182A05F53808504011079830A13F4642CB9EDF3E03B449725BB43E3529CD1E4FE42F16DE79469AD1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375AC38C7EC4509C8B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CFF8C34A7694A7E2E4482973F0FF06BA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC1F3D1E7C87716A07A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACDF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE652FD71AFB96DC7D28F6BDBBAB179F4ED8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F254576263B31EA9AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B81950166D0EFC69EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A57A9C6A66C056E55C3E06AF16F7E970FF55DB32F8A77CCCC6F87CCE6106E1FC07E67D4AC08A07B9B01DAA61796BF5227BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF4FE79DBC14C9B2BC469CDB0C0D8087591508C1290CBF9229AA6727473E447DC86F890FCD3CEE011B62C9293813A964D651833EFF578873E4FE1F6652948A25EE54CE6006BCE07E73 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiHgmeVjUOtIrKQB8Qwz8yQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5310CDF486FBEF4F8B722EECE5F6DD56FBD1BAB7CFCD36B6FB82326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Limit path length passed to C library loader. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, considering the fixes for Sergey comments. On 16.03.23, Maksim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall > > (cherry-picked from commit 90e65514dda3994253c1e3007f63da7ace8f6b7b) > > C library loader uses `dlopen` under the hood, which fails, if > provided library path is longer than PATH_MAX. PATH_MAX is > 4096 bytes by default, so a corresponsing check is added to > `ll_loadfunc`. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#8069 > --- > Side note: Still no adequate constants like PATH_MAX... > Side note: There is no test for successfull loadlib, since > there is one in the PUC-Rio suite. > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/c-library-path-length > PR: https://github.com/tarantool/tarantool/pull/8449 > > src/lib_package.c | 7 ++++++- > test/tarantool-tests/c-library-path-length.test.lua | 13 +++++++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/c-library-path-length.test.lua > > -- > 2.37.1 (Apple Git-137.1) > -- Best regards, IM