From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Limit path length passed to C library loader. Date: Thu, 30 Mar 2023 17:36:03 +0000 [thread overview] Message-ID: <ZCXIg/y3Djf4BWq3@tarantool.org> (raw) In-Reply-To: <20230316161720.78669-1-max.kokryashkin@gmail.com> Max, Thanks for the patch! LGTM, considering the fixes for Sergey comments. On 16.03.23, Maksim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall <mike> > > (cherry-picked from commit 90e65514dda3994253c1e3007f63da7ace8f6b7b) > > C library loader uses `dlopen` under the hood, which fails, if > provided library path is longer than PATH_MAX. PATH_MAX is > 4096 bytes by default, so a corresponsing check is added to > `ll_loadfunc`. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#8069 > --- > Side note: Still no adequate constants like PATH_MAX... > Side note: There is no test for successfull loadlib, since > there is one in the PUC-Rio suite. > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/c-library-path-length > PR: https://github.com/tarantool/tarantool/pull/8449 > > src/lib_package.c | 7 ++++++- > test/tarantool-tests/c-library-path-length.test.lua | 13 +++++++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/c-library-path-length.test.lua > <snipped> > -- > 2.37.1 (Apple Git-137.1) > -- Best regards, IM
next prev parent reply other threads:[~2023-03-30 17:43 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-16 16:17 Maksim Kokryashkin via Tarantool-patches 2023-03-17 11:17 ` Sergey Kaplun via Tarantool-patches 2023-03-17 12:54 ` Maxim Kokryashkin via Tarantool-patches 2023-03-30 17:36 ` Igor Munkin via Tarantool-patches [this message] 2023-05-25 6:16 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZCXIg/y3Djf4BWq3@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] Limit path length passed to C library loader.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox