From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3137B14BD7D; Fri, 17 Mar 2023 14:28:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3137B14BD7D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1679052530; bh=fBWtv8kwvnvn40rZYlvTZQ+/ykcYILfyzuMH576svEQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=M7FTe4PSONe2GVt14DCsRKoukQYGNn1IhVPu0ymP0Fv7DtDhJ2tedsHLTG+C4rWPC Pdi703TqLSCeVIEe1uqKRR9JCAmgp7htcvK7RgAjBKnwIagvJrgaS7U4786aNk6xH2 ApP3+Y/tvvqD0VfXTDIbxs2CMpmNXEAGwi5FD5RM= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C05E814BD7D for ; Fri, 17 Mar 2023 14:28:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C05E814BD7D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1pd8GN-0007ZB-Sc; Fri, 17 Mar 2023 14:28:48 +0300 Date: Fri, 17 Mar 2023 14:25:04 +0300 To: Maxim Kokryashkin Message-ID: References: <790098febd3a94337e892e4d7b1444ad1495b154.1678794695.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <790098febd3a94337e892e4d7b1444ad1495b154.1678794695.git.m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9303C7CA6F8B0D1ABBB800F553CDA9A4A144E0924AC84E0D1182A05F538085040FFC5F2F09170325101B1139A53C48D177A8FDC022C13A1B2FE9E14101DB15BAF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637317AD06F2A8D0AEF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AFDA67DA79F64180F0112EE8986BB2F8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF070A1BC70AFFF2BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACDF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E3E1DC0F9BD55309DEBD0B2718F2597EEDF55C41BCD4B22947E16242558B5F30516022683DE039801D7E09C32AA3244C23671F615AE27F730538C77E0A51B723A8CE788DE6831205927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBy9lRm6Il0tGI7gGW900hg== X-DA7885C5: F30B97D6EDC8BD216A5B8272018210C566074B9782E16F497EC707CF8DCD6E10262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF51E030742D6845D5CEFD7CD456F6D8ADE0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Please, consider my comment below. On 14.03.23, Maxim Kokryashkin wrote: > The test is extremely fragile and it is burdening > to fix it in scope of every major change. > --- > test/tarantool-tests/lj-603-err-snap-restore.test.lua | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/lj-603-err-snap-restore.test.lua b/test/tarantool-tests/lj-603-err-snap-restore.test.lua > index 6eb53dfd..2f2eec7d 100644 > --- a/test/tarantool-tests/lj-603-err-snap-restore.test.lua > +++ b/test/tarantool-tests/lj-603-err-snap-restore.test.lua > @@ -2,7 +2,9 @@ local tap = require('tap') > -- Test to demonstrate the incorrect JIT behaviour when an error > -- is raised on restoration from the snapshot. > -- See also https://github.com/LuaJIT/LuaJIT/issues/603. > -local test = tap.test('lj-603-err-snap-restore') > +local test = tap.test('lj-603-err-snap-restore'):skipcond({ > + ['Too fragile, temporarily disabled.'] = true > +}) I've reverted your patch at the last commit (4d5e9afe) and everything working just fine. I suggest to drop these changes. > > test:plan(2) > > -- > 2.39.0 > -- Best regards, Sergey Kaplun