From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1924A12E2508; Thu, 20 Mar 2025 15:38:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1924A12E2508 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1742474315; bh=fcHxVSEfdHeNcWJigy6MPEjmRciXpwR/oIGCYiCmqXo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BdGqxRA1RmwvdWgIWC/B+5PPBFyhfPqmtMatz8rt/HIM+p4T8E5BNlwuN0q5dFSoB rV1KctO5vREUzdnvWhusdBxTxaPSu5Xj8kgraI40wbjClwm6pCSz4p4/LSU+Vmu63W k2Tau4dEGoUxcIV/grunnYeyWFkE9vwpPDSuEZfo= Received: from send195.i.mail.ru (send195.i.mail.ru [95.163.59.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 15FB812E2508 for ; Thu, 20 Mar 2025 15:38:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 15FB812E2508 Received: by exim-smtp-75f69ddc6c-7r8bn with esmtpa (envelope-from ) id 1tvFAO-00000000SSp-0ofe; Thu, 20 Mar 2025 15:38:33 +0300 Date: Thu, 20 Mar 2025 15:38:34 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250227160013.2040-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92A53477891B58793DCF94335131206D40D1B920360E5D1A3182A05F538085040DCD80462BE6A411D3DE06ABAFEAF6705821E5D80A40327E65D44AD7DC96CECE04212A8CB8A084C4A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2C3D254D93F012B1C2E070BE324C7D3C44CC3E965A69ED9D9F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE7588D3C263EAE74EA731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5A0A87D01AC9D26DF5002B1117B3ED696E760439A7850D4C714DB8790748E3E77823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C2E47CA9A56060906EF7E6CCC8F905C5916FA1FB6DA62283B551C80F0760A802F0A64D71302B22531D7E09C32AA3244CED0158EC3DBFE3DF77DD89D51EBB774266803C1639FE37F3EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRxnlmV4XzQl53D1uKHCAEs= X-DA7885C5: 978E1F13F25D891BF255D290C0D534F9C47886F6BD6E6002ECA8FCDBDD0BF8869861A7515CEBB0625B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA2197AA861C244FA296CD8CFB3F1034D7481E8C4E55252E14AFFE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix IR_ABC hoisting. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments, rebased the branch on the tarantool/master and force-pushed it. On 20.03.25, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! LGTM with minor comments that can be ignored. > > Sergey > > On 27.02.2025 19:00, Sergey Kaplun wrote: > > From: Mike Pall > > +local function test_func() > > + -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant > > As usually we care about readers, I propose to make text more > human-firendly: > > s/1/The first/ > > s/2 and 3/second and third/ > Fixed, see the iterative patch below. =================================================================== diff --git a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua index 3a78c34e..57fbc584 100644 --- a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua +++ b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua @@ -39,9 +39,10 @@ local table_new = require('table.new') jit.opt.start('hotloop=1', '-fuse') local function test_func() - -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant - -- and variant parts of the loop. The trace is run via an - -- additional call to this function. + -- The first iteration for hotcount warm-up. The second and + -- third are needed to record invariant and variant parts of the + -- loop. The trace is run via an additional call to this + -- function. local limit = 3 -- Create a table with a fixed array size (`limit` + 1), so all -- access to it fits into the array part. =================================================================== > > + -- and variant parts of the loop. The trace is run via an -- Best regards, Sergey Kaplun