From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 51E8A129639F; Thu, 13 Mar 2025 13:28:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 51E8A129639F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741861710; bh=Z1p/fVk77GoKdOzj7i5vqVYe0pVUVwtfliIkwq3CSkw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G7CeQyPlgY8vdgecRAsuOxL3VECeV53d9daZiuwE8o0+jsyK3uPxs+aXi59DWQ2yF zM7KMqyMmUe+u3fqig9kMk5OsT/kmAPdFsIYRp1ftMoWSxzWLVNakVtSIgPsrkByyq kjVjP8fhG6xnCJeCJp6MWaU4We0DVIWVauaB+jag= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7EB381296395 for ; Thu, 13 Mar 2025 13:28:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7EB381296395 Received: by exim-smtp-69cc44787d-5tss2 with esmtpa (envelope-from ) id 1tsfnf-00000000Fz1-1kEZ; Thu, 13 Mar 2025 13:28:27 +0300 Date: Thu, 13 Mar 2025 13:28:28 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <47c0d447e3d2a49da2678bf065da1a55eae0e9c3.1741617766.git.skaplun@tarantool.org> <21c40859-1aeb-4152-a5d6-4f82a4c8f5fe@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21c40859-1aeb-4152-a5d6-4f82a4c8f5fe@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9CB00722163A93FBB14DC3116C8C2C75655C5A67E5A00BA6FCD62213F67905E7A76248C50517966955F024EB8E4F9CA96F022EA45EC01F8F2FB355C75F821A5C951CE0648C9E8651D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D34FAA3D8B31588C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6759CC434672EE6371C2A783ECEC0211ADC4224003CC836476D5A39DEEDB180909611E41BBFE2FEB2B3DACF72EAB9AF3FFDA182B4DA27AEC71CBFC3D48D6914F5141B71C8E0670B3549FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BECADA55FE5B58BB7A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CFA80D66F452D417A43847C11F186F3C59DAA53EE0834AAEE X-87b9d050: 1 X-C1DE0DAB: 0D63561A33F958A59FB1B357AEDCFC535002B1117B3ED696ACB960397918117C5D145BB8EF0DE66B823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F1ADD4D8CD3C81CE4F62BBC4E8EF570A6A361A67287F925DAF311FB967B471A8E877DC4968651EFD1D7E09C32AA3244CD2E076DF71FEE80D77DD89D51EBB77427B48C646949C4C0BEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2sXEAFjQ4X2GA= X-DA7885C5: 72D48803201FBC7FF255D290C0D534F9F67D1C8FE8173E5856E32DC684A04F924AFAD5EC888C23BB5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA21920DAB415E8FB8FDD6053EB085A0207E649927FABE60303ABE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 12.03.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM wit ha minor comment. > > Sergey > > On 10.03.2025 17:51, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by Sergey Kaplun. > > > > (cherry picked from commit eee16efa77b542e99c8e546a3d52fc023925c7bc) > > > > This commit is a follow-up to the previous one. It fixes the case when > > the `topslot` is adjusting for simple concatenation results. This patch > > adds the update of the corresponding Lua stack slots to be restored. > > > > This fixes back the test. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > It is partially true actually :) > > s/and the test// Yes, the force of the habit (and copy-paste ;)) > > > > > Part of tarantool/tarantool#11055 > > --- -- Best regards, Sergey Kaplun