From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BB17A12882C4; Tue, 11 Mar 2025 15:38:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB17A12882C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741696731; bh=YHf6p/CvSIRTOAFKAAPF3gUkvqNVGSNSH+p3gujBPD4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Od3Y5N+b7kx0GRsCdZHsDCVWxBfJIAS+uoqi4s4SVK4xGiIqSHFoCVuDB/bjyhHYV Fxp3GHj9ha0OwW0x3aaGYH4RuU7+WCPaelwKg9IhaqCH4tAWovW7LO5jKmQEUH6dC1 rWOJiq0BR8c244exPmgimS1LL+waUCvyhwxkUD6Y= Received: from send173.i.mail.ru (send173.i.mail.ru [95.163.59.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 313FF451814 for ; Tue, 11 Mar 2025 15:38:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 313FF451814 Received: by exim-smtp-69cc44787d-vpqw5 with esmtpa (envelope-from ) id 1trysj-00000000Vzy-0mXz; Tue, 11 Mar 2025 15:38:49 +0300 Date: Tue, 11 Mar 2025 15:38:50 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <8ee07c5f-6326-4618-bc3f-247efa79c46a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ee07c5f-6326-4618-bc3f-247efa79c46a@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E8ECD36702C4DEF5759A17906E51B6522D7160A8CA0CAA0182A05F538085040C49CA80F1622F8DF3DE06ABAFEAF670588292EB8F67262FB8A0EBFB2BBF6EA52B7E140D37D564E50 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375666DAE1D1A19A1A03ECE51C63EC0E43C01FEEC325834C13AE5A05ACBBDCD75DFA9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0DEC8C2C8BCD2534D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E232F00D8D26902CA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CB0EC3B1FCAE4A06943847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A50ACA0A9256C575975002B1117B3ED696F6EFD4E5BEAC8357F5FEB6EB1EB183FD823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D04880C2AE5E22CA4351124AA37F40BC1F338C6BCE72B3A0F619E26A6285614B32C7E1D7E09C32AA3244C0E309C2AE25D49B577DD89D51EBB774209E3B48BA0424770EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2soEnwfyDcRJo= X-DA7885C5: 9CD1D4B5819A77ABF255D290C0D534F98CA7DF29C798D1712A9B481706115DEF8ABBF9006427BB715B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219F5EA966A8E2B6DE55C523831AB970353197FBF5E10E12BB9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: unify helpers for a custom allocator setting X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 11.03.25, Sergey Bronnikov wrote: > Hi, Sergey! > > Thanks for the patch! LGTM with two comments below. > > Feel free to ignore. > > Sergey > > On 10.03.2025 17:51, Sergey Kaplun wrote: > > This patch merges two Lua C libraries that contain custom Lua allocators > > with the injection of returning `NULL` into 1 library > Minor: s/1/a single/ Fixed. > > . The new library contains 2 helpers: > Minor: s/2/two/ Fixed. > > * `enable_null_alloc()` -- returns `NULL` on every allocation (not > > reallocation). > > * `enable_null_doubling_realloc()` -- returns `NULL` on every > > reallocation that doubles the size of the object. It can be useful for > > testing corner cases, like OOM during IR/snapshot buffer reallocation > > during trace recording. > > The original allocator is returned via the `disable()` library function. > > > > The unified library helps to avoid code duplication and can be reused > > for future tests. > > > > Needed for tarantool/tarantool#11055 > > --- -- Best regards, Sergey Kaplun