From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 61FC61320063; Wed, 5 Mar 2025 18:12:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61FC61320063 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741187563; bh=Z2c+fSC8VgUJYmmwvpR1pf5ZbfAvlXy1nEtFKo7/qxc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=a6rPWTH85cam+EigizMrqVuOXT4H9YAo61eTkn4+m1mSja4gofkSok3IPZWg008Ol uPX+blpkuD/swIOS3mnYdal0F5aaMlmB5SpHXuDS6XiGI+TqM9zmnxQkBfNB74fAfR ZvOdLKzXDmTAqJfpjVqa+N7VrTkmdr+MBHUxAezE= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4D2FE1320062 for ; Wed, 5 Mar 2025 18:12:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D2FE1320062 Received: by exim-smtp-8cb569c79-lfxh7 with esmtpa (envelope-from ) id 1tpqQL-00000000WSf-1VD4; Wed, 05 Mar 2025 18:12:41 +0300 Date: Wed, 5 Mar 2025 18:12:41 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <6f39b239-083c-4508-a364-1ba02b3b5ed3@tarantool.org> <7c01b6c6-36f0-45d4-acb8-d26577254796@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7c01b6c6-36f0-45d4-acb8-d26577254796@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C8AED3E6A44DB6ABEC63A9DF2CB5B3BBD6066351508D60E5182A05F5380850405BA5317A57A0326D3DE06ABAFEAF6705742DB7332C87ADEB1B4A8E48FAFD2319E5BD31BE838A11F7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71EAE3A63419E5AEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566AE3F01DD33DDBDC8BD5D4553B55C9B3FD340736E07BF404E21B769830C7FB1C5389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B66EA1BA7CA28B4A74CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249EDF998CB16CCEE6976E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B7FE970921847EE7F3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73542F54486E6D6388DC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D960BED36097259C5002B1117B3ED6968E7E7DA686EA5312E41E333F9D1358D5823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C974B02B4EA30DFB6B7BE731BA4CC7325023C80ACF7B479D1D33890AE83FD0EAE29594419EF8B9411D7E09C32AA3244CB4FD77439470AA4A77DD89D51EBB77429E597202CCE78225EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2s2zFw8fpSx/4= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B591C19849385C8D59D3DE06ABAFEAF6705742DB7332C87ADEBB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 8/8][v3] memprof: set default path to profiling output file X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, with a final nit below. On 05.03.25, Sergey Bronnikov wrote: > Hi, Sergey! > > Updated and force-pushed. > > Sergey > > On 05.03.2025 13:57, Sergey Kaplun wrote: > -  local _, _ = misc.memprof.start() > - > -  local res, err = misc.memprof.stop() > +  local res, err = misc.memprof.start() > +  -- Want to cleanup carefully if something went wrong. > +  if not res then > + test:fail('sysprof was not started: ' .. err) > +    os.remove(default_output_file) > +  end > > +  res, err = misc.memprof.stop() >    -- Want to cleanup carefully if something went wrong. >    if not res then > + test:fail('sysprof was not started: ' .. err) Looks like it should be: "was not stopped successfully". >      os.remove(default_output_file) > -    error(err) >    end > > + >    local profile_buf = tools.read_file(default_output_file) > subtest:ok(profile_buf ~= nil and #profile_buf ~= 0, >               'default output file is not empty') > > -  -- We don't need it any more. > +  -- We don't need it anymore. >    os.remove(default_output_file) >  end) > -- Best regards, Sergey Kaplun