From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6EC1B126B77C; Tue, 4 Mar 2025 18:40:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EC1B126B77C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741102854; bh=hwH8Ax0WPa7PmS4R2NbjyOkIyI92mL2/U+MGBhAQwDk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AJYihy/1o+h77KFV+edOBhzZBr36p0hG0IDPq3uX8ViUbMRvYiyWrHrvHVWY1XsU0 zawsDcquoMKf3ibGRLqj3ZufH5vBu+q6rW444s1pMS7732my/zWybFrlXJKQGofnyq 2mu54d1pLcMKRME2IWD4f5od+Cj1TziyQ89VdHr4= Received: from send241.i.mail.ru (send241.i.mail.ru [95.163.59.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 701784E3D7D for ; Tue, 4 Mar 2025 18:40:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 701784E3D7D Received: by exim-smtp-848fbd8fb5-s6nps with esmtpa (envelope-from ) id 1tpUO3-00000000Kyq-1t81; Tue, 04 Mar 2025 18:40:51 +0300 Date: Tue, 4 Mar 2025 18:40:49 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <80360fb2e570ce8d54ff59ccf0bcd5dfb6b98527.1739362814.git.sergeyb@tarantool.org> <93178b00-f3e0-4145-932f-bd273935a477@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A2A28D6C22EE4403DBEA6F251FF4739B7AB3779B42495BF6182A05F538085040A95AAB9CAA6AF8283DE06ABAFEAF67050427E0462662008501710F72B1B262374662B04911350A54 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D5B197C6EC5B4BE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2133C5DF870D086E92E070BE324C7D3C41EB0DB18D01A461AF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3335407143AA9223635872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A59CC26ECF5106531F5002B1117B3ED6969CF1A78B0E275BEAF09842853758E9E5823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D16EA493CC1FD9F8880DFD98702AF4BC04456D3CCC4D3F99A6255BE1EF69174472B1F1EBBF6F60DD1D7E09C32AA3244C49615C28915C474677DD89D51EBB77423505096DFAEBC529EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2sFt3R59CObls= X-DA7885C5: 9DC9044148A22150F255D290C0D534F99745ED3932A769D73ED288946C6BCA603184D6FEFF1297CD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219FC56D351F3E4B1760B08D4874438BE33771BEB515CD48B02E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit][v2] Always close profiler output file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes, LGTM. On 27.02.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for review! > > Changes applied and force-pushed. > > Sergey > > On 26.02.2025 14:58, Sergey Kaplun wrote: > >> What is a rationale for this? > > As I said before, this is an additional possible demonstration of the > > bug. I see nothing bad to add it as well, since it simulates a little > > bit different workload -- flushing the output before we finish the > > process or if we unload the module. I am not insisting on it, though. > > How often users unload profiler's module? For me, this case looks artificial The following module [1] is used to reload all Lua modules (including `jit.p`). It was used for any Lua package update or code modification. [1]: https://github.com/moonlibs/package-reload Also, it is not only about unloading the module but also about finishing the process too (as you first discovered). This looks like a real use case. This variant of the test is just simpler than creating a child process and checking its result files. > and the final goal for us is not a demonstration, but covering a code > touched by the patch, > > it is done by proposed test. > > (I'm really confused that on review I learn more and more new > requirements to the patches It is not a requirement, just a suggestion. See the last line of my comment. I'm OK with reproducing the issue only since it is not the vital part of the code. > > like adding all available testcases that cover a patch or that code > should follow C89 or > > that using etc.) > > The bug fixed by the patch is quite minor, it will not break production > and will not kill humans etc. > > I believe a single testcase and time that we both spend on doing > backport, test and two iterations > > of review is more than enough for this patch. Moreover, jit.p is not > used by Tarantool users, > > we provide our own profilers to them. So, just ignore it then. > > > >> This is a helper script for LuaJIT profiler and according to our > >> backporting rules > >> > >> test must cover a backported patch. This rule is fulfilled by my test. > > > > -- Best regards, Sergey Kaplun