From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3C503F265C0; Mon, 24 Feb 2025 12:46:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C503F265C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1740390384; bh=kegrbsszs487hOHG1FQ7XqHmKra/HcXvs8HDc3Qkg9k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gs646/jQl/Ku7JqJVIynCzLJiFaviit6IQh7fBdZk6ZglM4lkwn2rKSBQwbqz3ygV FwtiD7+LBbvCD+GqrjH42PLU7MVwKIqQ02XcWWNG0g6ZY71G/Z0gVniB9pdxof6z8m vMVbOMItycZ69ePIhVyaPxxZu2QH5fsyTvXh6wkc= Received: from send58.i.mail.ru (send58.i.mail.ru [89.221.237.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 085D0F265C7 for ; Mon, 24 Feb 2025 12:46:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 085D0F265C7 Received: by exim-smtp-5556bfdb98-mqz2c with esmtpa (envelope-from ) id 1tmV2b-00000000Cul-4AGs; Mon, 24 Feb 2025 12:46:22 +0300 Date: Mon, 24 Feb 2025 12:45:40 +0300 To: Sergey Bronnikov Message-ID: References: <6990a0f3b661498e2c4c7697f5da4cfe4e35ffe4.1740050074.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6990a0f3b661498e2c4c7697f5da4cfe4e35ffe4.1740050074.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD916C41472748AFA0499A5DCC2C2C98BDF5DC6DE94BD03B46E00894C459B0CD1B973AB4E22A9ADF2310578E6996F383413084ABE3F8DA9F0F4173DD500188237E835AA1534FA60CA86 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A431CDDF496E6E598638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A3E0069DFED3577F9D542C18002254C9F46B5EFA552E94CCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637BA939FD1B3BAB99B389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063796140BF0DA724314D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE73745307B7F32D572EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3335407143AA9223635872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A520A93992D048D4EB5002B1117B3ED696718C208EC1B79FABB91D2EB2DEE3878C823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34060C3C6DE316ECE49A7A339310CBE8A228DF39FE376DE009B42EB77896D8F041A39B7B1C8AF096851D7E09C32AA3244C1A8118A10DEF02DE77DD89D51EBB7742877C4C8FAD7F974EEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQQG/FugD0/Cw5C1mXQDbSI= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B595315934A82A529383DE06ABAFEAF670540480180AD964051B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/8][v3] test: introduce flag LUAJIT_DISABLE_MEMPROF X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, except a few nits regarding the commit message. On 20.02.25, Sergey Bronnikov wrote: > The patch introduce an environment variable LUAJIT_DISABLE_MEMPROF Typo: s/introduce/introduces/ > needed by tests in suite `tarantool-tests` for skip testcases when Typo: s/suite/the suite/ Typo: s/for skip/to skip/ > memprof is disabled in build. Typo: s/build/the build/ > > Needed for the following commit. > --- -- Best regards, Sergey Kaplun