From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 74750F23539; Mon, 24 Feb 2025 12:40:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74750F23539 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1740390055; bh=S8Fdnhj+w84vkqM01TaX4cedl6FXQIdfRy2NQel5p0M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Z7zJS3bXBnMRn05yxeNhNq6azmxIL8M+80INadTLybQOJ3snskPHpKmVaSpkbu+EN DODAg4TAlJdu4074y2DpVX1kLUNSl0Z8J4+jAsWTyy5wbnBW6iNmiOIPsE2tTSiYk/ SRZMQzGT/FhsTFP8kT+QelMdxk4wzE6C2FZMzdqQ= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0494B534024 for ; Mon, 24 Feb 2025 12:40:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0494B534024 Received: by exim-smtp-5556bfdb98-zrswb with esmtpa (envelope-from ) id 1tmUxI-00000000Qzd-2uPr; Mon, 24 Feb 2025 12:40:53 +0300 Date: Mon, 24 Feb 2025 12:40:11 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD916C41472748AFA0453D9C7FE68DF4451D80261D9949172CF00894C459B0CD1B9458A85B1E14B52D24BD03525DDD6C896E8C791EE30D9DBD974C6D230CA73BC6883F5067A33008722 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377A06FA5CCF78F9BC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F04558427A9797535A5969F774FFC3E748AB9781B5FF2F2CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063796140BF0DA724314D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE73745307B7F32D572EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C37C6C241D9975906435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5955852E366DC7EAC5002B1117B3ED69620AC351BD72AD19D6E5F408120975D33823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340A4C04F5DECA7EE98F1B65F68BFC17C722CECF3C57477C26DE96161DE0F1D1D7A9571F2A1FBC81351D7E09C32AA3244CF2C98F85D87053FA77DD89D51EBB77423BF1C012BDA85AAAEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQQG/FugD0/COlcYwcjDruY= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B594FA26C9F097003283DE06ABAFEAF67056481DF05B7C301B1B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/8][v3] test: align test title with test filename X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, except a single nit regarding the commit message. On 20.02.25, Sergey Bronnikov wrote: > The patch fixes TAP test title to make it aligned with test > filename. Inconsistency introduced in commit > efd7e1a67de24464e1e83793e16eac6df443e3c0 > ("test: make skipcond helper more convenient"). I am afraid that this naming was introduced in the first commit related to the tests (sysprof and memprof). So we either should mention 2 initial commits or just omit this part. -- Best regards, Sergey Kaplun