From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8FB6512E4543; Wed, 19 Feb 2025 18:42:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FB6512E4543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739979746; bh=CFb6BhTWk+TPTKsMvrz9d+CbFc9TLSct+kIEGmQ3Dh8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Aj3IrB/Ni83uHm4JwEwzIWqN4utD604mxtJY8KcUo4D3D7HAjGGSPrc+3B80SQV4y fofcxvePLDaDJB6Ml0I5ROItSdSjlPYWZ19XDq8x7OSvaQsCpcUx2wScwSwvKtabE2 dG7193dyGgzN1+0K8w/AbRxT81dII41VU0/IWeWA= Received: from send175.i.mail.ru (send175.i.mail.ru [95.163.59.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CA97212E4540 for ; Wed, 19 Feb 2025 18:42:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CA97212E4540 Received: by exim-smtp-5f589487f8-bgc9k with esmtpa (envelope-from ) id 1tkmDQ-0000000073W-2p7R; Wed, 19 Feb 2025 18:42:25 +0300 Date: Wed, 19 Feb 2025 18:41:43 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <7f83ca101b76bba7b5789a6c5a7e9acb8044fed1.1739444510.git.sergeyb@tarantool.org> <73448ddd-5b78-4e89-a45b-0407fca1396f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73448ddd-5b78-4e89-a45b-0407fca1396f@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD916C41472748AFA04C2817BA953C7B1C761AF83692520876400894C459B0CD1B98446055CF0CC52F891417EB218679B821A377C88486E0402D466CDA61916532A1E0A116AA96AFE1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE4525FFB91B9BBCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B05885A782BE20C5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C905D353A959F31382EC7DD04FD59AA87944F0AF7F9180A5333A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFE06F720CA742837ABA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B67F378122B062093B76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C468D16C903838CAB43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5576612373D99107E5002B1117B3ED69654015509FBD4CB3CBFF4097FFC9E796F823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D345C110A855FC09999ED779FCBB9DB6929F296897C1492085DA80BA3807CDA238F7944ECDBFF8F9F651D7E09C32AA3244C9CBC13019A58FB7E77DD89D51EBB7742A49F65AE4E10E6E2EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWiyXSWEEqdro9OIdgrDzAk= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B5947885F9E83801AC03DE06ABAFEAF67056D71123E13B24764B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 6/7] misc: specific message for disabled profilers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! On 19.02.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for review! > > On 19.02.2025 11:06, Sergey Kaplun via Tarantool-patches wrote: > > It's more LuaJIT-way to use something like the following: > > | if (!LJ_HASSYSPROF) { > > | /* ... */ > > | } > > > > This helps to avoid strange early return. > Fixed. > > Also, please be avaired to declare all variables (stataus, opt, > > err_details) in the beginning of the block. > >  It is a requirement for the code that strictly follows c89, when you > must declare all of your variables at the beginning of a scope block. > > AFAIK, we have no such requirement, and also there is no option > "-std=c89" in CI and no any mentions in the contribution guide. This is not mentioned in Tarantool's contribution guide, since it is LuaJIT-specific. In the perfect world, it should be checked by the flags mentioned in (see the second CWARN). Unfortunately, there are some bugs that should be fixed first. -- Best regards, Sergey Kaplun