From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 81D0CF3C687; Tue, 18 Feb 2025 14:10:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 81D0CF3C687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739877055; bh=MjzmI+Qrpf1V//KEbAuU+zpzpRdNSno6OR2n5BTRlZ4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GZCW7nLXIerIp6etnBHTQ/e3IL+ngy3kfdvfZByVSEMoCuApXcYQVreoxWwB2GSlI CZ0Hc8s5vD0Zd3T+ZHtx9XQSunP2tFbErJwF29kYQH9o8T094QFH+5kGEm+DbGWIpv o6KygJJSrn8FcUksc4GxUOJqMkrLmq22BRx9xwGw= Received: from send220.i.mail.ru (send220.i.mail.ru [95.163.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9DCFBF3C688 for ; Tue, 18 Feb 2025 14:10:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9DCFBF3C688 Received: by exim-smtp-844687bc8-xt2v6 with esmtpa (envelope-from ) id 1tkLV7-0000000044K-2hFd; Tue, 18 Feb 2025 14:10:54 +0300 Date: Tue, 18 Feb 2025 14:10:12 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD916C41472748AFA04F2C5B9934FEF480AAF226148868F92ED00894C459B0CD1B9BECD9A04633F9281D4FF92D56319F1973E0518F0DAFB5A8CDC373F344029FA05E26C7FC155FDCB66 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DD7A7F9003AF293F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D848C1621D5450753ACDD6E21E66A41744B56BEBE0FF104C85CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8ED96AA85C75E140D117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A58F1875A35A87410C5002B1117B3ED6961A3337D5DDF053620E58516B1639A14B823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D344A431191C56981FEDABBAB5EEC7A44CD6596FB898E86501AB28685826D821017BC5B1698FAFAF5DD1D7E09C32AA3244C91795B7920C9477077DD89D51EBB7742501A33420F177FFFEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWiyXSWEEqdrHH6nGQKvwv4= X-DA7885C5: BD614E53C08A17DFF255D290C0D534F9B3CA50B97F05B6F7A0E872A0B8C762B4FE350ED99E9E0E785B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219BD1FA486F30249CA7F8093ED7D093D0F46B1525A511E26A9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks fro the patch! LGTM, except a minor nits below. > sysprof: align test title with test filename It should be `test:`, since we don't change the sysprof component itself, only test for it. On 13.02.25, Sergey Bronnikov wrote: > The patch fixes TAP test title to make it aligned with test > filename. Inconsistency introduced in commit > efd7e1a67de24464e1e83793e16eac6df443e3c0 > ("test: make skipcond helper more convenient"). I am afraid that this naming was introduced in the first commit related to the tests (sysprof and memprof). > --- > test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +- Should it be fixed for the memprof too? > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > index 237143ad..32fa384c 100644 > --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > -- > 2.34.1 > -- Best regards, Sergey Kaplun