From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E69FEF3CD5D; Tue, 18 Feb 2025 15:11:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E69FEF3CD5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739880680; bh=bWt1WNKF95K9qjovgd8sNMQY08DIX/KcY5lNE+FMVnk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QmnaZ+WHToZVhoS/c/p3zxSlC2m41zc/icjCCCmp+oMQGfeOeDDl6ogkdLiNsLQco BRNl9cPwyaxiunV6cEIH0tL/ZqosB68RKYgiCJT1T+HKlizynP+fHhymI7gFEz+Fg2 wrSTYArbf5Soz6czBZQyB+cISaoWbyUiZMwaIHR4= Received: from send152.i.mail.ru (send152.i.mail.ru [89.221.237.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CAD97F3CD40 for ; Tue, 18 Feb 2025 15:11:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CAD97F3CD40 Received: by exim-smtp-844687bc8-frwp8 with esmtpa (envelope-from ) id 1tkMRZ-00000000GT1-2uGv; Tue, 18 Feb 2025 15:11:18 +0300 Date: Tue, 18 Feb 2025 15:10:35 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <4defed95d90fee0536d841337b134220d493823e.1739444510.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4defed95d90fee0536d841337b134220d493823e.1739444510.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD916C41472748AFA04C2817BA953C7B1C761AF83692520876400894C459B0CD1B9EA1FBA7CE2FC2D9A479CDAE959BF642448E73349E0DE20A56BDF45958DB086704B72E82432766FBE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375ECBB839B6BB0AA98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84C960BDF4FF0A32DAF8B0A0B06389AF5D453F8F5BDC91F0ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5FACF204095A59B135002B1117B3ED696D462561374E892D0CA7E60A991436CA2823CB91A9FED034534781492E4B8EEAD8D8BB953E4894305BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFC2404EF8B92A4D2E9DD3E5F6B750BA3BFAD594853DB56DCFDC01CBE0DE1FA98A5C1052AD1686EE730526A8B1FD8BF66B51E935A33E629B1FDEC8CD5541EEF07612377C067F8AF72B111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWiyXSWEEqdr3x7bg7tLEyU= X-DA7885C5: 444585355DDB9A52F255D290C0D534F93F3871B5DC6032288FD2384F51B8B89DE8BF42B3243D05125B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219251DE02C85B8A2FEF13CF97F540AABA2CA592CE60FC5CFD9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/7] ci: add workflow with disabled profilers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, with a minor nits below. On 13.02.25, Sergey Bronnikov wrote: > Needed for the following commit. > --- > .github/workflows/exotic-builds-testing.yml | 6 +++++- > test/tarantool-tests/CMakeLists.txt | 4 ++++ > .../gh-5994-memprof-human-readable.test.lua | 1 + > .../profilers/misclib-memprof-lapi.test.lua | 15 ++++++++------- I suggest to split this commit into 2 separate (both of them are LGTM though): 1) Introduce `LUAJIT_DISABLE_MEMPROF` flag in cmake and tests. 2) Add the corresponding exotic workflow. > 4 files changed, 18 insertions(+), 8 deletions(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 374c879b..70b55423 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -34,7 +34,7 @@ jobs: > BUILDTYPE: [Debug, Release] > ARCH: [ARM64, x86_64] > GC64: [ON, OFF] > - FLAVOR: [checkhook, dualnum, dynamic, gdbjit, nojit, nounwind, tablebump] > + FLAVOR: [checkhook, dualnum, dynamic, gdbjit, nojit, nounwind, tablebump, noprof] Please sort entries alphabetically. Here and below. > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > @@ -54,6 +54,8 @@ jobs: > FLAVORFLAGS: -DLUAJIT_NO_UNWIND=ON > - FLAVOR: tablebump > FLAVORFLAGS: -DLUAJIT_ENABLE_TABLE_BUMP=ON > + - FLAVOR: noprof > + FLAVORFLAGS: -DLUAJIT_DISABLE_MEMPROF=ON -DLUAJIT_DISABLE_SYSPROF=ON > exclude: > - ARCH: ARM64 > GC64: OFF > @@ -72,6 +74,8 @@ jobs: > # (`DASM_S_RANGE_I`). > - FLAVOR: tablebump > ARCH: ARM64 > + - FLAVOR: noprof > + ARCH: ARM64 > runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}'] > name: > > LuaJIT ${{ matrix.FLAVOR }} > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index 9bacac88..a6d09dc7 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > index f3041779..0ab9c57c 100644 > --- a/test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > +++ b/test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > @@ -7,6 +7,7 @@ local test = tap.test('gh-5994-memprof-human-readable'):skipcond({ > ['No profile tools CLI option integration'] = _TARANTOOL, > -- See also https://github.com/LuaJIT/LuaJIT/issues/606. > ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), > + ["Memprof is disabled"] = os.getenv('LUAJIT_DISABLE_MEMPROF'), Please use single quotes for this file (for the consistency). > }) > > local utils = require('utils') > diff --git a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > index ce41e4d5..33925c7f 100644 > --- a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > @@ -8,6 +8,7 @@ local test = tap.test("misc-memprof-lapi"):skipcond({ > jit.arch ~= "x64", > -- See also https://github.com/LuaJIT/LuaJIT/issues/606. > ["Disabled due to LuaJIT/LuaJIT#606"] = os.getenv("LUAJIT_TABLE_BUMP"), > + ["Memprof is disabled"] = os.getenv('LUAJIT_DISABLE_MEMPROF'), Please use dougle quotes for this file (for the consistency). > }) > > -- > 2.34.1 > -- Best regards, Sergey Kaplun