From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A730EF29452; Mon, 10 Feb 2025 18:19:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A730EF29452 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739200768; bh=2/R307FRR0yI3XH2hKvYDwPVG2c5ClU5lmCrCmOF2Cw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qY7CCJIIKDFo0caFkc3yvJLnaF40as3Wc/lP9U0eHolrw5ePkSxTa2AkHM7T/7MVK NNkB8jvx2Bts63hHldXkcP6zL6wFV8xEhLXHYcf3TD/cQ3lW1+TeYz9mmeYUOyXuMn 4P+oNQGObGu2ZEYxr4EWmOS33e0H+AtsWMWM5UFQ= Received: from send174.i.mail.ru (send174.i.mail.ru [95.163.59.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 537F2F29452 for ; Mon, 10 Feb 2025 18:19:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 537F2F29452 Received: by exim-smtp-5c664d6544-99xz4 with esmtpa (envelope-from ) id 1thVZG-00000000KmF-17wf; Mon, 10 Feb 2025 18:19:26 +0300 Date: Mon, 10 Feb 2025 18:18:39 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250207130500.10406-1-skaplun@tarantool.org> <3e8e566a-35ad-4895-89af-afbb67acd38e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e8e566a-35ad-4895-89af-afbb67acd38e@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD980EDB4062763125EAFF16E40C854B1E7D68A8EB2592E4D7400894C459B0CD1B9C0DB5D2E78E0C06B15C513EAE8123D4DB109891708113345FA14896FFDAB1E3D6464624B37E45577 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77633BACAB33B9508C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE760302A529BCAAAFCEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C90F903662378278F4B6A7A2FF598F4C721A4E8F184E5128305A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7FCC1818C568F6B8AD32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C005273F62ACD9011ACD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F0CC24CB7C056FEE5002B1117B3ED6963F1524B3DB3B79233D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3414C91BA6844B96CAA14B8C23EB6C7AC576ACEE5302C3A99A2C136AC39BEBC9569478CBA9A30A51B41D7E09C32AA3244C17AB1E585BFD151C77DD89D51EBB77425FF730FFA2A81FA2EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj4p5EDZXZmhHrxKmNh+n7TQ== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59A193580275E13B2A3DE06ABAFEAF67056E364C28A0ABD13CB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix recording of BC_VARG. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 10.02.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 07.02.2025 16:05, Sergey Kaplun wrote: > > > > > > +jit.opt.start('hotloop=1') > > +test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording') > Typo: "corect" Fixed and force-pushed to the branch. Also, rebased to the current master. See the iterative patch below: =================================================================== diff --git a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua index 20b43e07..b3a62b5c 100644 --- a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua +++ b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua @@ -31,6 +31,6 @@ local function test_func(...) end jit.opt.start('hotloop=1') -test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording') +test:is(test_func(EXPECTED), EXPECTED, 'correct BC_VARG recording') test:done(true) =================================================================== > > + > > +test:done(true) -- Best regards, Sergey Kaplun