From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7D0317744F5; Mon, 10 Feb 2025 17:52:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7D0317744F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739199145; bh=0t4l73G7qCa2ITf2RPwldYh3rkNv1o2oQjPMPtPVpfg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YZbWT3BfE8OifmW7RCkG+hOQwjnTuvLcz2D8DTwFleWeS62pQcGq2p4rfOFXWh+hD PQ0jQJXW8rffTueBP9/Yyej9nLmAF8rlgGmFnUmjuvp5+MCBBojmDK3EI7dbf8Bzzp BIHQ+pEBE6179Pj+wviPevYJEYrXGEhJkQmDgP/I= Received: from send60.i.mail.ru (send60.i.mail.ru [89.221.237.155]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2023A7744F5 for ; Mon, 10 Feb 2025 17:52:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2023A7744F5 Received: by exim-smtp-5c664d6544-bzj2w with esmtpa (envelope-from ) id 1thV90-0000000087E-1QYw; Mon, 10 Feb 2025 17:52:18 +0300 Date: Mon, 10 Feb 2025 17:51:32 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <6ff0d573c1bc2302729c6c7e3b62a264f413b4f0.1738663201.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ff0d573c1bc2302729c6c7e3b62a264f413b4f0.1738663201.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD980EDB4062763125E13F299063487B86D3BF7A9673D8B889D00894C459B0CD1B95E2C64B525CE8428C7A4B249DE6549FD7A8F95DBD1C4A290A2623FF0697791C335485DF4C51D0362 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379A70878BADDF00B98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C113D8C43C63FD5266AF38A00688AE6B836FAB3E21170D5DCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006370F9B9C81FEA0DEC7D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE78F84DE33370BE923EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3483320834B361D1F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A518EAFFE703E533C85002B1117B3ED696D2CFD77A2C57574630E4A65F242F5898823CB91A9FED034534781492E4B8EEAD0D89974173551D4FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D348BE83DFD8AFB1CACDD8E7444C0EB425E81650465AAC9CD3B30071FADF89FB7DD47E94547B98DCD071D7E09C32AA3244CB44DC6838FF94E9777DD89D51EBB77421EA4E34CCB217972EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojy7TIew8PonGtfJ8FAXDdHA== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59A7D16752BCED8A333DE06ABAFEAF670522AEBEAD1C4EEFD8B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] sysprof: fix typo in the comment X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, with a few nits below regarding the commit message. On 04.02.25, Sergey Bronnikov wrote: > The patch fixes inconsistency in comment and source code below > the comment. The typo was added in the initial commit > 2593a9f83072 ("misc: introduce Lua API for new sampling profiler"). Please use the full commit hash. I know that this is enough too, but: a) It would be consistent with other commit messages. b) There is less probability of the collision between hashes. Maybe it is worth to mention "Follows up tarantool/tarantool#781" (the sysprof ticket) if you want (I am not sure that this is needed, since it is only the comment). > --- > src/lib_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib_misc.c b/src/lib_misc.c > index ca1d1c75..5b7a4b62 100644 > --- a/src/lib_misc.c > +++ b/src/lib_misc.c > -- > 2.34.1 > -- Best regards, Sergey Kaplun