From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 74749F08EC0; Fri, 7 Feb 2025 13:51:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74749F08EC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1738925471; bh=+NZHZcwqgHDqxSntZ+EpUUrHmMA119FL+b8bHZt7e/s=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Tby9hXfgo5MYIbemyT8laI1lqj6bsvGxRzNYHQWQitmJ95rdgroJncwEvWqsVDSvb g0enBvZQzu2zZxspPjKt1VSInbxCpkGHIAClQKXvbw8pfX1J9K8lmI8KfDvTEN07aU /1YC/VUkD51MVS11vU4iqRAG5wekNyowkmGyXqww= Received: from send37.i.mail.ru (send37.i.mail.ru [89.221.237.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D8FA1EF79FB for ; Fri, 7 Feb 2025 13:50:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D8FA1EF79FB Received: by exim-smtp-5c664d6544-gkdvz with esmtpa (envelope-from ) id 1tgLwc-00000000P9v-43Qh; Fri, 07 Feb 2025 13:50:47 +0300 Date: Fri, 7 Feb 2025 13:50:04 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD980EDB4062763125E46509C30DE0B2FA7386222A1FA08B15D00894C459B0CD1B9650BF1CDCED655AD06104296DCCA83D210AF2BAB94C675FBED35E8BF9E43961EEC456C66D2279EA7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D4A2B7BAC4DEDB8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377EB37407B8EEC8CE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86A004AF146A2EE831ED4841C9F31530C5D89332502C627DCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5EE76E934129F6CE35002B1117B3ED69628B43230B5DE69DA8B25839F35DFE037823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349A949488F6BF46DD83C0B608A5C86DA7AB37ED5371795869BB9892280DCBB01975BF5A0B2FF23F4E1D7E09C32AA3244C75E03243FB8791A877DD89D51EBB7742DAEE37C68D8969E3EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaieVYTt/pxR2BlS48lGe7g== X-DA7885C5: A427EE44571F9644F255D290C0D534F945A087C1410997254DEA49F2498C4A11FE72312BE3C60C005B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219C0AA81B8B8A33E0D87EF655D42247716A323C994264FAB42E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit][v2] Handle all stack layouts in (delayed) TRACE vmevent. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, after fixing a bunch of nits below. On 06.02.25, Sergey Bronnikov wrote: > From: Mike Pall > > --- > Branch: https://github.com/tarantool/luajit/tree/ligurio/lj-1087-vm-handler-call > > Related issues: > - https://github.com/LuaJIT/LuaJIT/issues/1087 > - https://github.com/tarantool/tarantool/issues/10709 > > Changes in the v2: > * Addressed comments by Sergey Kaplun > > diff --git a/src/lj_trace.c b/src/lj_trace.c > index 94cb27e5..6b97cc13 100644 > --- a/src/lj_trace.c > +++ b/src/lj_trace.c > diff --git a/test/tarantool-c-tests/lj-1087-vm-handler-call.test.c b/test/tarantool-c-tests/lj-1087-vm-handler-call.test.c > new file mode 100644 > index 00000000..ebdf63e1 > --- /dev/null > +++ b/test/tarantool-c-tests/lj-1087-vm-handler-call.test.c > +/* XXX: Still need normal assert inside writer functions. */ Minor: Since there is no writer function, I would rather use the following wording: | Still need normal assert for sanity checks. > +#undef NDEBUG > +#include > + > +/* > + * Test file to demonstrate a segmentation fault, when C function Typo: s/C function/a C function/ > + * is used as a VM handler in LuaJIT: Minor: `as a VM handler for trace events` is a little bit more verbose. Feel free to ignore. > + * > + * Program received signal SIGSEGV, Segmentation fault. > + * 0x000055555557e77d in trace_abort (J=0x7ffff7f9b6b8) at lj_trace.c:615 > + * 615 lj_vmevent_send(L, TRACE, > + * (gdb) bt > + * > + * See details in https://github.com/LuaJIT/LuaJIT/issues/1087. > + */ > + > + /* > + * The number 32767 is `REF_DROP - REF_BIAS`. It will be better to rephrase the next sentence. > See the commit > + * 0fdf06b456e6 ("test: relax JIT setup in misc.getmetrics > + * test") for the details. > + */ I suggest the following comment. | This is the maximum possible IR amount, so the trace is always | aborted. The amount of text to read is approximately the same, but we don't need to look into the mysterious commit anymore. :) > + int res = luaL_dostring(L, "jit.opt.start('minstitch=32767')"); -- Best regards, Sergey Kaplun