From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 13919EF79F8; Fri, 7 Feb 2025 13:50:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 13919EF79F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1738925442; bh=B/voTv96w8DUb8uOCkB4aM9o7HntOwTaObuFEFjbWS4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=RR26dDYS7psYHCw8Mj9hqSH+r3t3pmIChSRVOsMmHyHEVm2pvO45tyo1r9zaWgQsd JxPjSbw2z3fRDEiEznBF3a57mJQFMWQ8VmPsCNjrRFBxNmx5WiOIxHDoBtJv5vNL8V Io699zKysbMcMVq4ZzB+SoZqoUoIiP/1MvwbC+VI= Received: from send127.i.mail.ru (send127.i.mail.ru [89.221.237.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D895253A8F6 for ; Fri, 7 Feb 2025 13:50:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D895253A8F6 Received: by exim-smtp-5c664d6544-rlrtc with esmtpa (envelope-from ) id 1tgLwT-00000000A9D-07Qa; Fri, 07 Feb 2025 13:50:39 +0300 Date: Fri, 7 Feb 2025 13:49:54 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <16d60884-cb3b-42c5-ab66-b20bf769b750@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16d60884-cb3b-42c5-ab66-b20bf769b750@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD980EDB4062763125E7489F14865191B44A2742F5B584B614000894C459B0CD1B9424B6A728DED26D0C591814E25D11F9FCDFA3462CFACF139ED35E8BF9E43961E42B98C014DDF718D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE75CCA5FD4E6ACD987EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C9029438826BEFD9EEA21D8DF46B9A4E220A36BF39A5C18E3B2A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A515BC7CED02012B2A5002B1117B3ED6964CF7860534977BAC250A03108B67251B823CB91A9FED034534781492E4B8EEADC24E78AA85F86F6CBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E3E1DC0F9BD553093906C1410B1BF38BCA6C52E69B7717E2ED65847F1499254B825BDACE4ED082981D7E09C32AA3244CB575C8EF204AF9B677DD89D51EBB774245DE3E306EE24FD4EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaieVYTt/pxTBepC7YzcstA== X-DA7885C5: 37B0AF0130E3F52EF255D290C0D534F9F041F730FB3F04DCBF2306A764E2DB4FDDAFD4A79B9655735B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA2192F5A706A51DB1C42FD46662F9E9CCF860854FDEB36D86494E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Handle all stack layouts in (delayed) TRACE vmevent. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes and the answers. On 05.02.25, Sergey Bronnikov wrote: > >> + lua_pushcfunction(L, (lua_CFunction)cb); > >> + if (event != NULL) { > > Nit: Brackets are excess. > > Feel free to ignore. > > Removed, anyway it is a test code and without braces it looks more clean. > > However, I'm always enclosing statements in loop/if/else in braces, > > because I remember about "goto fail" issue [1]. > > 1. https://dwheeler.com/essays/apple-goto-fail.html Side note: I believe that the reason here is not the goto `usage` or code without braces. But this is more like a philosophic question to discuss. :) -- Best regards, Sergey Kaplun