From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F377C12905D3; Fri, 14 Feb 2025 18:36:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F377C12905D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739547381; bh=nifyNSBi8pHmd0nhZ49a1FA6aVo/0um59FvQ2jeAKgM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xiu2m/1z0E7KWFtXGeXP3Zo5oYc5p8uD8dnnQExmokIu8b0NNljFw01UhnyneVUgl wQ5+ntbz8sRdbi+qFWe8wURJvBhs53LJCvpRzs62TJTslRbfQTli1zWq879FL+28F3 +lIo5g7Ky2yy8KM42H+aiMJzCycG5zPiweT0Q1/g= Received: from send173.i.mail.ru (send173.i.mail.ru [95.163.59.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F0E0342080C for ; Fri, 14 Feb 2025 18:36:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F0E0342080C Received: by exim-smtp-844687bc8-vt4zf with esmtpa (envelope-from ) id 1tixjm-00000000Wjx-4158; Fri, 14 Feb 2025 18:36:19 +0300 Date: Fri, 14 Feb 2025 18:35:34 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <9f6e14af248c0514c0c3f813e216676457a177be.1739362574.git.sergeyb@tarantool.org> <18776d28-113c-44ac-8c8a-b1966f4ea2f5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18776d28-113c-44ac-8c8a-b1966f4ea2f5@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD93899CACFFF273C59D98F8A13D04471E2C241410585FE7DCB182A05F5380850405DEDB7CB5D4F2D653DE06ABAFEAF67059C8D389D0A76471000FC77A3E902C3118B3EAEBA3E028A83 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063752AC809489EC5B9C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83DAC55B0D8382FE62E5DE235469028E4ECC604B399CC3ECFCC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8C2B5EEE3591E0D35F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A51720C1340A1DDB485002B1117B3ED696DBB50CAC03B3B0FB957033528158102E823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF74B391AEE7C3F66C951CC5BD3E335702A8B5B14BAB62922B4D08C82F9C795AD5284AB208DE0D1BB1856F99080E561BE19EE56CA0A6F80C729BC29C3F9ADE58BE7DB859F1CBBED8FB5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JLyxlCMHyJC27TEfSK/c0LqN2oB/DnvPkw== X-DA7885C5: 163F101D21AD1939F255D290C0D534F9FFF8A398ECB6F99B869F5E182A9EF4CC7169E7DC3CEB915E5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA2199C1C2247AEC85E52CC7CBECC1778CAC0E5F4245CBC31ECF6E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit][v2] test: limit code and comment max length X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! LGTM! I've also aplied the following patch to your branch after rebase on the current tarantool/master: =================================================================== diff --git a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua index b3a62b5c..f4d222f9 100644 --- a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua +++ b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua @@ -1,8 +1,12 @@ local tap = require('tap') +-- luacheck: push no max_comment_line_length +-- -- Test file to demonstrate incorrect recording of `BC_VARG` that -- is given to the `select()` function. See also: -- https://www.freelists.org/post/luajit/Possible-issue-during-register-allocation-ra-alloc1. +-- +-- luacheck: pop local test = tap.test('fix-recording-bc-varg-used-in-select'):skipcond({ ['Test requires JIT enabled'] = not jit.status(), =================================================================== -- Best regards, Sergey Kaplun