From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B6853122AE1C; Thu, 13 Feb 2025 16:50:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B6853122AE1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739454658; bh=kgjSpzOavlVkciFothgdkPfiKRWip8QCTZlm0cqy4wU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cQfxhRnN3tNBJNy2AEnzNQqeSLdG8jHhaZCuCMkIyko82QENgrz2Sj69uflpuntOv xbH1Bxb7mFvWDRt1uqKg/YzCGSBiffXA3NTQQQfYijiERl6375PklHvD2iPipAYHd7 o1CNFcDDpGhjXEBmPuoR9NIix2eM554BO8JC+pD4= Received: from send58.i.mail.ru (send58.i.mail.ru [89.221.237.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 37D5A122AE1C for ; Thu, 13 Feb 2025 16:50:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 37D5A122AE1C Received: by exim-smtp-844687bc8-sr8pn with esmtpa (envelope-from ) id 1tiZcG-000000006ky-0lpt; Thu, 13 Feb 2025 16:50:56 +0300 Date: Thu, 13 Feb 2025 16:50:11 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <9f6e14af248c0514c0c3f813e216676457a177be.1739362574.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9f6e14af248c0514c0c3f813e216676457a177be.1739362574.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93899CACFFF273C5934367BECE3B45A9BD91423C8D63114E5182A05F538085040405520228FD54B2F3DE06ABAFEAF6705B79E090B920EA8DD2142153D519ABA6BD5D5E52AFDF0C1B1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2EC3597058CFA6DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637107AA061ADD8C4B78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E0006EECBB5FA8883F3F1372031DD204A852BDD04A521B76CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8989FD0BDF65E50FBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5B7F5E884644141175002B1117B3ED696BD7521B98747B8EF19AC5B239BAD4335823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF64D088AADA318E654A513A9D252E5FD53992E79550F0CA37CA164F078A664824B9228B76B87D064D856F99080E561BE1D3A2604B30CAF635B630DAE21CDD2F8777E2ED1630819CCD111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JLyxlCMHyJC2d0TEC2RcdP96lCefroij2w== X-DA7885C5: A4F902268F608502F255D290C0D534F9EC9F184229AF00FB339AD5BA59200D3106B7FEF07B4F59E75B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA2191E594DE2EF2914D9D779199261548598704791E4E6683D3FE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit][v2] test: limit code and comment max length X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the decent work! I've checked, at a rough guess, that there are no line numbers to be updated in these changed files. LGTM, with an ignorable suggestion below. On 12.02.25, Sergey Bronnikov wrote: > The patch sets a max length with 80 symbols for lines with code > and max length with 66 symbols for lines with comments in luacheck > configuration file [1] and fixes files where this length is > exceeding. > > 1. https://luacheck.readthedocs.io/en/stable/warnings.html#line-length-limits > --- > Changes v2: > - Added fixes according to comments by Sergey Kaplun. > - Reduced a max length of lines with comments (80 -> 66). > - Fixed warnings triggered by reducing max limit of lines with > comments. > > Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-set-max-length > > .luacheckrc | 3 + > .../fix-argv-handling.test.lua | 4 ++ > .../fix-binary-number-parsing.test.lua | 2 + > .../gh-3196-incorrect-string-length.test.lua | 3 + > ...gh-4773-tonumber-fail-on-NUL-char.test.lua | 9 +-- > test/tarantool-tests/gh-6163-min-max.test.lua | 68 ++++++++++++------- > .../gh-7745-oom-on-trace.test.lua | 3 +- > .../lj-1004-oom-error-frame.test.lua | 6 +- > .../lj-1116-redzones-checks.test.lua | 2 + > .../lj-1149-g-number-formating-bufov.test.lua | 4 +- > .../lj-366-strtab-correct-size.test.lua | 17 +++-- > .../lj-416-xor-before-jcc.test.lua | 28 ++++---- > .../lj-494-table-chain-infinite-loop.test.lua | 14 ++-- > ...lj-505-fold-no-strref-for-ptrdiff.test.lua | 3 +- > .../lj-524-fold-conv-respect-src-irt.test.lua | 4 +- > .../lj-603-err-snap-restore.test.lua | 6 +- > ...-611-gc64-inherit-frame-slot-orig.test.lua | 2 + > .../lj-611-gc64-inherit-frame-slot.test.lua | 2 + > .../lj-624-jloop-snapshot-pc.test.lua | 4 +- > .../lj-688-snap-ir-rename.test.lua | 2 + > .../lj-737-snap-use-def-upvalues.test.lua | 3 +- > .../lj-819-fix-missing-uclo.test.lua | 49 +++++++------ > ...-865-cross-generation-mach-o-file.test.lua | 4 ++ > ...lj-918-fma-numerical-accuracy-jit.test.lua | 4 ++ > .../lj-918-fma-numerical-accuracy.test.lua | 4 ++ > .../lj-962-stack-overflow-report.test.lua | 3 +- > .../lj-962-stack-overflow-report/script.lua | 3 +- > .../mark-conv-non-weak.test.lua | 2 + > .../misclib-getmetrics-lapi.test.lua | 9 ++- > .../or-144-gc64-asmref-l.test.lua | 4 ++ > .../or-232-unsink-64-kptr.test.lua | 24 ++++--- > .../profilers/gh-5688-tool-cli-flag.test.lua | 3 +- > .../gh-5813-resolving-of-c-symbols.test.lua | 9 +-- > .../gh-5994-memprof-human-readable.test.lua | 3 +- > ...17-profile-parsers-error-handling.test.lua | 3 +- > tools/sysprof/parse.lua | 6 +- > 36 files changed, 206 insertions(+), 113 deletions(-) > diff --git a/test/tarantool-tests/mark-conv-non-weak.test.lua b/test/tarantool-tests/mark-conv-non-weak.test.lua > index 73c24b66..fe0969cf 100644 > --- a/test/tarantool-tests/mark-conv-non-weak.test.lua > +++ b/test/tarantool-tests/mark-conv-non-weak.test.lua > @@ -4,6 +4,7 @@ local test = tap.test('mark-conv-non-weak'):skipcond({ > }) > > test:plan(1) > +-- luacheck: push no max_comment_line_length I suggest the following patch instead to prevent the warning only for necessary part of the IR dump: =================================================================== diff --git a/test/tarantool-tests/mark-conv-non-weak.test.lua b/test/tarantool-tests/mark-conv-non-weak.test.lua index 73c24b66..4396ee58 100644 --- a/test/tarantool-tests/mark-conv-non-weak.test.lua +++ b/test/tarantool-tests/mark-conv-non-weak.test.lua @@ -9,20 +9,22 @@ test:plan(1) -- instruction is emitted. See `loop_unrool` in `lj_opt_loop.c`. local data = {0, 0.1, 0, 0 / 0} ---- XXX: The sum is required to be initialized with a non-zero --- floating point value; otherwise, `0023  + num ADD    0017  0007` --- instruction in the IR below becomes `ADDOV` and the `CONV int.num` --- conversion is used by it. +-- XXX: The sum is required to be initialized with a non-zero +-- floating point value. +-- Otherwise, `0023  + num ADD    0017  0007` instruction in the +-- IR below becomes `ADDOV` and the `CONV int.num` conversion is +-- used by it. local sum = 0.1 jit.opt.start('hotloop=1') --- XXX: The test fails before the patch only --- for `DUALNUM` mode. All of the IRs below are --- produced by the corresponding LuaJIT build. +-- XXX: The test fails before the patch only for `DUALNUM` mode. +-- All of the IRs below are produced by the corresponding LuaJIT +-- build. --- When the trace is recorded, the IR --- is the following before the patch: +-- luacheck: push no max_comment_line_length +-- When the trace is recorded, the IR is the following before the +-- patch: ---- TRACE 1 IR -- .... SNAP #0 [ ---- ---- ---- ---- ---- ---- ---- ---- ---- ] -- 0001 u8 XLOAD [0x100dac521] V @@ -104,6 +106,8 @@ jit.opt.start('hotloop=1') ---- TRACE 1 exit 0 ---- TRACE 1 exit 2 -- +-- luacheck: pop +-- -- Before the patch, the `0022 > int CONV 0017 int.num` -- instruction is omitted due to DCE, which results in the -- third side exit being taken, instead of the second, =================================================================== Thoughts? > -- XXX: These values were chosen to create type instability > -- in the loop-carried dependency, so the checked `CONV int.num` > -- instruction is emitted. See `loop_unrool` in `lj_opt_loop.c`. > @@ -114,6 +115,7 @@ jit.opt.start('hotloop=1') > -- > -- Note that DCE happens on the assembly part of the trace > -- compilation. That is why `CONV` is present in both IRs. > +-- luacheck: pop > > for _, val in ipairs(data) do > if val == val then -- Best regards, Sergey Kaplun