From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C0B07F09715; Wed, 29 Jan 2025 17:55:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0B07F09715 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1738162555; bh=huEvnih13MQJq9Udl3ZZ30uCMOZ2OgYTFUEqDHAvel0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TkkH8QakgpQbvprhseP/Gi+t11rU4hKTFovvXj2g5fscFUfdYDwuBgsMMaac75ZBg B9/r3+9eS3q369f3IaPLl5/0AKgQUYsL35v6Eue/9xob6uuWESEj1KXAPjQ5wpCyfR in3ky4oALUQyO939pEdLm+SewLQB/SJd4LuRH4pQ= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0C9AAF09718 for ; Wed, 29 Jan 2025 17:55:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0C9AAF09718 Received: by exim-smtp-5bf6658466-zdvld with esmtpa (envelope-from ) id 1td9Tt-00000000JPk-3vnm; Wed, 29 Jan 2025 17:55:54 +0300 Date: Wed, 29 Jan 2025 17:55:16 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <9b29c3fc69a0245861959fe80a322dc84ba8160b.1738143566.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b29c3fc69a0245861959fe80a322dc84ba8160b.1738143566.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98096D77EEA3F473C0E3A337D8275D5468624D779D0C73C44182A05F538085040E4C7A00A2D1AF8A73DE06ABAFEAF6705185FE970A994CB656F1D7BBAE995A900B323337538F1B82C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70D278D70F8433719EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D7045943A292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C3DD9AEFB8068FEFAE2ABD947F765C3DEE7F324373E2224CCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D882D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3856009BA58C5E1BBBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5BC41AC0E74B7B4B45002B1117B3ED6968E65CA25ABE26FEC33EE06AFCD964888823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A2EC120135420F903925A7F4CFF408DF2AC5D23D0A695DACB64EE80ED7CB9877BFCA959348C90E1B1D7E09C32AA3244C164B9F00A4F1DF5677DD89D51EBB77429E84D2032CE42838EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7lkpqFEzmFAnz9eoVpGg7Q== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59671E2A0D9B281DA63DE06ABAFEAF6705185FE970A994CB65B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: define UNUSED macros only once X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, with a minor comment below. On 29.01.25, Sergey Bronnikov wrote: > The macros `UNUSED` is widely used across the suite Typo: s/macros/macro/ > `tarantool-c-tests`. The patch defines macros only once in Typo: s/macros/macro/ > `test.h` to reuse it in other tests and removes definitions in > tests. > --- > > Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-define-unused > > diff --git a/test/tarantool-c-tests/test.h b/test/tarantool-c-tests/test.h > index 3b22fb92..c1717932 100644 > --- a/test/tarantool-c-tests/test.h > +++ b/test/tarantool-c-tests/test.h > @@ -4,6 +4,8 @@ > #include > #include > > +#define UNUSED(x) ((void)(x)) Minor: I suggest to wrapping this into the `#ifndef`, since the `UNUSED()` is a very common macro. The same one is used in the LuaJIT. For now these macros are the same [1] but to avoid rewriting code in the case of the changes, it is better to use `#ifndef` directive here. > + > /* > * Test module, based on TAP 14 specification [1]. > * [1]: https://testanything.org/tap-version-14-specification.html [1]: https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html -- Best regards, Sergey Kaplun