From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 85F7EF19370; Tue, 28 Jan 2025 12:37:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85F7EF19370 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1738057035; bh=kn+3/QnLbvznXKZL2Z5gKbhXDu8y0doAkyUSPMjzU1Q=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IaOibIfTSOqzIP4WbTRuwybsYNYbRHNr/7+XLsCoRGyPsU7BRp+1ubyw7akAd1rWr sC0F8Hnwg8IZafsipiXCvfPwRFtY0aB6i0EfH62fEEz9lk2nSNyyZQewo3GdKy0XGD DTOx827zjirPTFyrgv68XjcjcNg6+MCTT03WCDwc= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66EA4F19349 for ; Tue, 28 Jan 2025 12:37:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66EA4F19349 Received: by exim-smtp-5bf6658466-lxzq7 with esmtpa (envelope-from ) id 1tci1x-00000000GH6-25uh; Tue, 28 Jan 2025 12:37:13 +0300 Date: Tue, 28 Jan 2025 12:36:34 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250127101814.23617-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD968032E0F70FD1A0C44C980B7B9F69390A5E71768B298231700894C459B0CD1B95332A748514AAFDF479CDAE959BF64240AD27342881D1070D0450B4AD73701424F193C0F926A29E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE788EDE44B2AC36D7BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377EB37407B8EEC8CE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80CCD4F3E0ACB019B41BE3CDD78ECA8D370BEF9461F4E36D7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D05AD665AB97B35DC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A56B37213E4C1F32A85002B1117B3ED696950537A7BDE6AF528B25839F35DFE037823CB91A9FED034534781492E4B8EEADB73CFAAED92B6E13BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEE6B00BB2619BBE5E81558C7C710038EFAC93E5DA52677D05B3A3C280FFFC595C7834276CD052397477492209842FC2B42517C7E06CBCF13018645088F885C7B651770655BDD0509111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLyxKgEujxHjbxFagu537sQ== X-DA7885C5: 1C2BB121695C4470F255D290C0D534F91244B3CA0309C6DA438D557467527B4832D52071606001B25B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219E841D02D60163110E33595901908670C3E1F3C81391AB8A7E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 28.01.25, Sergey Bronnikov wrote: > Sergey, > > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 27.01.2025 13:18, Sergey Kaplun wrote: > > > > > > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt > > index c4a402d0..c84c651d 100644 > > --- a/test/tarantool-c-tests/CMakeLists.txt > > +++ b/test/tarantool-c-tests/CMakeLists.txt > > @@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}") > > foreach(test_source ${tests}) > > # Get test name without suffix. Needed to set OUTPUT_NAME. > > get_filename_component(exe ${test_source} NAME_WE) > > + > > + # Test requires static build, since it inspects internal > > + # symbols. > > + if(exe STREQUAL "gh-8594-sysprof-ffunc-crash" > > + AND BUILDMODE STREQUAL "dynamic") > please put AND to the previous line and fix indentation > Fixed, thanks! =================================================================== diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt index c84c651d..32a8add0 100644 --- a/test/tarantool-c-tests/CMakeLists.txt +++ b/test/tarantool-c-tests/CMakeLists.txt @@ -44,8 +44,8 @@ foreach(test_source ${tests}) # Test requires static build, since it inspects internal # symbols. - if(exe STREQUAL "gh-8594-sysprof-ffunc-crash" - AND BUILDMODE STREQUAL "dynamic") + if(exe STREQUAL "gh-8594-sysprof-ffunc-crash" AND + BUILDMODE STREQUAL "dynamic") continue() endif() =================================================================== -- Best regards, Sergey Kaplun