From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BC7F3E72A00; Fri, 17 Jan 2025 11:32:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC7F3E72A00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1737102728; bh=YjJaWG2G8PVM9D5Ju1R9OYDCo8ZqpysGTVXtgWi9jsc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gRXSxDBkZMqw1aHLBa3Or+wIHvs9+3IcQbi/Lg1BgMvvfXWJ5toB8sCTvQ26SzfYq AIhAqNA29gYQ6Vf8435U9InJ1Q7+HhuEU2A4VKXPBRvNb0mrbYJ7u0yBVyMRvNdnDH XyyND6CvbSZRORSUAQ1Mgi8HlBjIRPD6Qah8cRYQ= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 444C74C9CEC for ; Fri, 17 Jan 2025 11:32:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 444C74C9CEC Received: by exim-smtp-6758d5575c-cjkqz with esmtpa (envelope-from ) id 1tYhlt-00000000S2E-46Y7; Fri, 17 Jan 2025 11:32:06 +0300 Date: Fri, 17 Jan 2025 11:31:27 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250116133559.2686-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9CAF828D4DCE9EB95BFAA8D562A54D49AD04F6FCF8DA73BBA182A05F53808504021DDC1EF96EA9E3B3DE06ABAFEAF6705CF06EB6BE11670139D056C49DDFD7BAA217A548D7C17D9D2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE702C8878A98595F58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374FA524FBD8B89EAA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D837AD6738C02F13C7CC6314FD11B50EBE581A3D203282863DCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A51BFFE56BC88F821C5002B1117B3ED696C59A3A6F291806A0C66B2B37046EC955823CB91A9FED034534781492E4B8EEADA79578C5CF9A9009BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7144CC1544D6D537797FF6301E0CD0A0192BCFB482710075D5F797C92F4FB98B284AB208DE0D1BB18239A89FD99B18750C226535A2AD0E0C5F0F0CB56391F1A4A3C2FEFDA07CCFDB111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWtbQUE8gyFy9EwcZHGUMTw== X-DA7885C5: B127EFC94763E3F9F255D290C0D534F9F93E079315B41174F65651100890C265AFB38BA460CAE1DF5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219985A37363D12FB50082057E87AF64151DC8647BC55A905E9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] x86/x64: Add more red zone checks to assembler backend. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments below. Branch is force-pushed. On 16.01.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See comments below. > > > On 16.01.2025 16:35, Sergey Kaplun wrote: > > > > > > diff --git a/test/tarantool-tests/lj-1116-redzones-checks.test.lua b/test/tarantool-tests/lj-1116-redzones-checks.test.lua > > new file mode 100644 > > index 00000000..70062ec9 > > --- /dev/null > > +++ b/test/tarantool-tests/lj-1116-redzones-checks.test.lua > > @@ -0,0 +1,118 @@ > > +local tap = require('tap') > > +-- Test file to demonstrate mcode area overflow during recording a > > +-- trace with the high FPR pressure. > > +-- See also,https://github.com/LuaJIT/LuaJIT/issues/1116. > > +-- > > +-- XXX: Test fails only with GC64 enabled before the commit. > I would rephrase: XXX: Test fails with reverted fix and enabled GC64. Rephrased as you suggested. See the iterative patch below. > > +local test = tap.test('lj-1116-redzones-checks'):skipcond({ > > + ['Test requires JIT enabled'] = not jit.status(), > > +}) > > + > > +test:plan(1) > > + > > +-- > > +-- [1]:https://wiki.osdev.org/X86-64_Instruction_Encoding#REX_prefix > > + > > +_G.a = 0 > > +_G.b = 0 > > +_G.c = 0 > > +_G.d = 0 > > +_G.e = 0 > > +_G.f = 0 > > +_G.g = 0 > > +_G.h = 0 > > +-- Skip `i`. > > I didn't get it. Updated the commit: =================================================================== diff --git a/test/tarantool-tests/lj-1116-redzones-checks.test.lua b/test/tarantool-tests/lj-1116-redzones-checks.test.lua index 70062ec9..4f4f5870 100644 --- a/test/tarantool-tests/lj-1116-redzones-checks.test.lua +++ b/test/tarantool-tests/lj-1116-redzones-checks.test.lua @@ -3,7 +3,7 @@ local tap = require('tap') -- trace with the high FPR pressure. -- See also, https://github.com/LuaJIT/LuaJIT/issues/1116. -- --- XXX: Test fails only with GC64 enabled before the commit. +-- XXX: Test fails with reverted fix and enabled GC64 mode. local test = tap.test('lj-1116-redzones-checks'):skipcond({ ['Test requires JIT enabled'] = not jit.status(), }) @@ -54,7 +54,7 @@ _G.e = 0 _G.f = 0 _G.g = 0 _G.h = 0 --- Skip `i`. +-- Skip `i` -- it is used for the loop index. _G.j = 0 _G.k = 0 _G.l = 0 =================================================================== > > > -- Best regards, Sergey Kaplun