From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E6B25F44B29; Fri, 10 Jan 2025 14:10:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E6B25F44B29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1736507454; bh=HjUvn/PZrootyZOKNVVdq5Qwcer7/ghfEyGEpld18Z0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=B60QUWLd2NL3Pe+CmhMTFTmYmmt1qwOdQihmygxlAorP8mIobiGu6+t6yzGty3kfH ybQdpwMUahGbsrntZvKnqvEAEoy4KEHqb8Kn6fphXT8wvJDr+2kSn5qMGbuEivUtdi Qwt57fGrD9/zbzw9hPyTLhXA9fOu/ajp3uYH3R9I= Received: from send58.i.mail.ru (send58.i.mail.ru [89.221.237.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB6C6F44B29 for ; Fri, 10 Jan 2025 14:10:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB6C6F44B29 Received: by exim-smtp-bcf9586c5-49kpv with esmtpa (envelope-from ) id 1tWCui-00000000Hbg-04Lc; Fri, 10 Jan 2025 14:10:52 +0300 Date: Fri, 10 Jan 2025 14:10:19 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250109150124.23841-1-skaplun@tarantool.org> <847b75f4-07a9-4c99-83b1-d9833197a82d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <847b75f4-07a9-4c99-83b1-d9833197a82d@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97C62A2C8925CC6477B512D1403DA219F1166050BB17CA73B182A05F53808504047BCA2F7FA94B4403DE06ABAFEAF670536BF439B1ADECD967F7288B95132212593525CDB3F0CE26E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D7F1BE85E7B0CA818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8292A4EF50E59FDB6ABB90AE28F1E4D20126E9AF4809D6708CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B3241B8C6B78F28F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A594E0F19DD0944A6F5002B1117B3ED696AF0F38B4E76F2023C89B063BDC7FAC35823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D15EDCC1FECC2586F181E576702B6865D6BE0ADE6586F44C3DEB2125CB3575EEE11D7E09C32AA3244CC9A0515D43D3ECCD77DD89D51EBB77424A8910A7F0C296CCEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXhNIkWce4y1mvfIW9x9Llw== X-DA7885C5: 70F81A3E461F8853F255D290C0D534F93AC50CC838C61EE74FDDA5E9F74B30720E69F8179222B2E05B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA21960F5ECB552DEB6CFD47ECE44A17B0D707DA441B5AE8A810BE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (for real now). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. On 10.01.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! > > test is passed with reverted patch. > > With original reproducer luajit segfaults. > > CMake options:  cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug > -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON You must run this test with Valgrind enabled to see the failure as it is mentioned in the commit. The original reproducer is clumsy and unstable -- any slight change of the parser may break it. This reproducer is much simpler, robust, and more readable. > > > Sergey > > On 09.01.2025 18:01, Sergey Kaplun wrote: > > +-- The parsing of the `for` iterator uses the incorrect check for > > +-- `fs->bclim`, which allows the usage of an uninitialized value, > > +-- so the test fails under Valgrind. -- Best regards, Sergey Kaplun