From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2AEF3DD8224; Mon, 23 Dec 2024 11:19:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2AEF3DD8224 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734941989; bh=sJvc7gMFSxOSGG9mvcV0HmdjziFiYVvDu+faxn3xv4M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=S0ecuEZ/gXmRlB6kAkiQpromlpGWk/2Q9N6gGZwrLkXQ+8k6y5zO5DAUnCw/TjDe3 OHfmtz4A+q0PCF1WS0Amm++vFWtvgTg32ejMG6VP9C/YgxUaxvaK1M/q+JfzIu2rCy /XjRwJNmLPypeH2wkwohtHjg5BBT+gr+0Xk8Bo8I= Received: from send127.i.mail.ru (send127.i.mail.ru [89.221.237.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A4B83DD8224 for ; Mon, 23 Dec 2024 11:19:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A4B83DD8224 Received: by exim-smtp-cc4f974bf-lx2r8 with esmtpa (envelope-from ) id 1tPdfG-00000000MYN-36eB; Mon, 23 Dec 2024 11:19:47 +0300 Date: Mon, 23 Dec 2024 11:18:48 +0300 To: Maxim Kokryashkin Message-ID: References: <20241219093041.14681-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90D1D1AB545089981BB5D0AB5B2E770D4604FC1B39F4235D1182A05F5380850401749E275CCA571363DE06ABAFEAF67051D1FB38B3F118AC14CBFA836A3F4A44BAB2D66377DC39A95 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375ABF1810CDE7D0E9EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C90DA7A17B339C619261C5B7B30811DB6BEC87B5E9178CAF725A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006371F24DFF1B2961425731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A57CFEE53B21044AB25002B1117B3ED696E5117441D9167155406406D89DD9EB8A823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34CA9B3B5DE5D383E6D39D2A726C6F2768D9919290D3F025B33047608678DB92936949935B3BA8953C1D7E09C32AA3244CB5531D02E61761F177DD89D51EBB7742F27B4887781FE8C0EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXozcCdatr+A9xmBJVpgEqg== X-DA7885C5: F0CF034CFF8E9C3BF255D290C0D534F9B347CBBBA8CF735D6B7F7939813BD8FF590A901EB2F05F385B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219655C5BCE19FF2D6FC3FECAA417861CF525AE03467891B70DE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 23.12.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit below. > > On Thu, Dec 19, 2024 at 12:30:41PM +0300, Sergey Kaplun wrote: > > The `strtod parsing` subtest in the checks > > the results yielded by the `strtod()` via FFI call. In glibc versions > > before 2.28 it returns an incorrect result (NaN instead of inf) for > > "0x3p1023" [1]. This patch hardens the skipcond for this test for a > > smaller version of the libc installed. > I believe these versions are usually referred to as `older`, not > `smaller`. Feel free to ignore. Replaced, as you suggested. Rebased branch on the current master and force pushed with the fix. > > Side note: I agree with Sergey Bronnikov here, we should really try > and push the operating systems that have reached their EOL out of > our CI, so we can focus on something that matters. Agree here too. > > > > > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279 > > --- -- Best regards, Sergey Kaplun