From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 644C75F7ED7; Fri, 20 Dec 2024 15:16:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 644C75F7ED7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734697003; bh=CT/1ZyO/CyPhQ8lD/DA6kyNGMeGJbIQ3oe2UggFWFGY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J1cDlhX2PMAkSm8dkfrpjdEHrGwhQdG1PHnU+0HKHQs3HqHA9ZOFeCwr15ZnazZW5 axg0/VWd3AZwx2g1NN+TLzd3OpV6Qncl6FHcgXXN5ztWxeCA428G2zS2Q4S2gKbdC4 qepwWJuFqrS7zpO02vfpGY+BghLpeqTD/gbfU/nw= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 027625F7ED7 for ; Fri, 20 Dec 2024 15:16:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 027625F7ED7 Received: by exim-smtp-cc4f974bf-qzsxt with esmtpa (envelope-from ) id 1tObvs-00000000RCs-1QYX; Fri, 20 Dec 2024 15:16:41 +0300 Date: Fri, 20 Dec 2024 15:15:40 +0300 To: Sergey Bronnikov Message-ID: References: <20241219093041.14681-1-skaplun@tarantool.org> <2730f6cc-ed1e-415b-9871-e1ac10dcd9c3@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2730f6cc-ed1e-415b-9871-e1ac10dcd9c3@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90D1D1AB545089981CF6DB1319E1340A03C13003BA84DF441182A05F53808504062D3B4BC876EC41A3DE06ABAFEAF670579E24C4F28EA5BB59CAB118109082E81D2B9C3C88B730D5B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86BB9AF60E20DA61DA0D6D9202620FB5DCAD1CCA1953391C7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D886E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3BED8D3449C78C548BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6957A4DEDD2346B4275ECD9A6C639B01B78DA827A17800CE7D699F3A2029486C7731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A54F67D67A25A8F5FE5002B1117B3ED696456F348950B50E21886DC9BC01168B20823CB91A9FED034534781492E4B8EEADA79578C5CF9A9009BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34697E0FA301E28215A0E90BD90B076E298C190C1EA1BAB089BADAE870A40C5A7FB81191164B24A6D41D7E09C32AA3244CD7E6E3B8C5DE790C77DD89D51EBB7742827D92DECB501386EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfZ9BPZgVRhosHwot5j5cLA== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59E1FCA441D32FB5573DE06ABAFEAF670579E24C4F28EA5BB5B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answers below. On 20.12.24, Sergey Bronnikov wrote: > Hello, Sergey, > > thanks for the patch! See comments below. > > > On 19.12.2024 12:30, Sergey Kaplun wrote: > > The `strtod parsing` subtest in the checks > > the results yielded by the `strtod()` via FFI call. In glibc versions > > before 2.28 it returns an incorrect result (NaN instead of inf) for > > "0x3p1023" [1]. This patch hardens the skipcond for this test for a > > smaller version of the libc installed. > > > > [1]:https://sourceware.org/bugzilla/show_bug.cgi?id=23279 > > --- > > > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions > > > > The CI failure for libc 2.23 (ubuntu 16): > > https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916 > Ubuntu 16.04 EOL and EOS are reached [1] > > The CI failure for libc 2.24 (debian 9): > > https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859 > Debian 9 EOL is reached 4 years ago [2] > > The CI failure for libc 2.27 (ubuntu 18): > > https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743 > > The CI pass for libc 2.31 (ubuntu 20): > > https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949 > Ubuntu 20.04 support ends in 3 months and 2 week [1]. Yes, unfortunately we should keep (AFAICS) these runners to check the installations for our customers. > > > > > > test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > > index ac7d68a4..800c57b0 100644 > > --- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua > > +++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > > @@ -186,9 +186,11 @@ do --- tonumber parsing > > test_conv(tonumber) > > end > > > > --- Skip for the old libc version with the bug in the `strtod()`. > > --- See alsohttps://sourceware.org/bugzilla/show_bug.cgi?id=16151. > > -do --- strtod parsing -libc<2.19 > > +-- Skip for the old libc version with the bugs in the `strtod()`. > > +-- Affected versions: > > +-- * <2.19:https://sourceware.org/bugzilla/show_bug.cgi?id=16151. > > +-- * <2.28:https://sourceware.org/bugzilla/show_bug.cgi?id=23279. > > I propose to skip strtod test when Glibc is older than say 2.30 [3] and > avoid testing > > with ancient Glibc versions because Glibc implementation is buggy [4] and > > a there are lot of bugs in old and more or less new versions: > > v2.41 [5], v2.22 [6], v2.27 [7], v2.15 [8], v2.33 [9] etc [10]. > > > I don't think we should waste our time with issues like this. > > > 1. https://endoflife.date/ubuntu > > 2. https://endoflife.date/debian > > 3. https://sourceware.org/glibc/wiki/Release > > 4. > https://github.com/tarantool/luajit/blob/cd5ab5da9b56bf560407554c0377cfa8567d4430/src/lj_strscan.c#L20-L27 > > 5. https://sourceware.org/bugzilla/show_bug.cgi?id=30220 > > 6. https://sourceware.org/bugzilla/show_bug.cgi?id=19380 > > 7. https://sourceware.org/bugzilla/show_bug.cgi?id=15744 > > 8. https://sourceware.org/bugzilla/show_bug.cgi?id=14049 > > 9. https://sourceware.org/bugzilla/show_bug.cgi?id=26137 > > 10. > https://sourceware.org/bugzilla/buglist.cgi?bug_status=__all__&content=strtod&no_redirect=1&order=bug_id%20DESC&product=glibc&query_format=specific Yes, I agree that this should be the last red line for us. If the test will fail again due to glibc, it will be easier just to drop it. For now, I see no failures for versions 2.31 -- 2.40, and find no bugs related to our tests that affected versions 2.28 -- 2.30, so let's skip it for versions less than 2.28 for now. > > > +do --- strtod parsing -libc<2.28 > > test_conv(function(s) > > local d = ffi.C.strtod(s, e) > > return (e[0][0] == 0 and #s ~= 0) and d or nil -- Best regards, Sergey Kaplun