From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BAE83E58A51; Mon, 16 Dec 2024 14:25:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BAE83E58A51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734348305; bh=AIQi0P0Tkv38WwF7Ghk5HNDZVAKEefMIjYA/bm2cWMA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=E0vaEZTbodnde8rpiOV/8XlOnDblOBfVDbAXcwHrO8rOeJLgVDT/335HA5t6l4ou+ MaJGF6Jy+mOhNh352pN6eIyoeN5igFqGwKfRZNXqQj7kBk7upPs6Wqv96dN/QmITi0 7+c0vXunVz0e+sNm2iyRQlpbsRBkP3k2YBWTQ/Fc= Received: from send34.i.mail.ru (send34.i.mail.ru [89.221.237.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E2FD253B852 for ; Mon, 16 Dec 2024 14:25:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E2FD253B852 Received: by exim-smtp-76d484c77c-mw5qf with esmtpa (envelope-from ) id 1tN9Di-000000003gn-3FIm; Mon, 16 Dec 2024 14:25:03 +0300 Date: Mon, 16 Dec 2024 14:24:02 +0300 To: Sergey Bronnikov Cc: Maksim Tiushev , tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD977EAE61095F37AC51EA5F1D68797ED6086F23A01EF220838182A05F538085040EFA1541AF32DD29B3DE06ABAFEAF6705F379EDB41292DC3FA61351E9118F93E5E742C8646DB18FBC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8D1333770DC60CDEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C900C5BA09AF19E758C251DA8930198BF40244D0E3A68CCA641A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF9A1C9D3BA3303E89BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6BFC5BFC0DB013F7476E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A56B8B307AAE5260405002B1117B3ED6965395EBAC6AFAE66A33EE06AFCD964888823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D342B1F2AD168155B0609411C7DA318061C12764A4838E7EFF562FE55CC0D6C6FB6CE6F0888E5A7A6041D7E09C32AA3244C8816CBEA30EC98AE77DD89D51EBB7742DABFAEA5AD6A7480EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaQ2NfKPcDQOfd27GQdXEpQ== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59F4789C9240F0BE4E3DE06ABAFEAF6705F379EDB41292DC3FB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 luajit 1/3] Ensure full init of IR_NOP instructions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 13.12.24, Sergey Bronnikov wrote: > Hello, Sergey, > > thanks for the patch! LGTM with a minor comment. > > On 11.12.2024 16:21, Sergey Kaplun wrote: > > From: Mike Pall > > > > (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234) > > > > Before this patch, Valgrind produces tons of warnings during the VMevent > > calls since the `IR_NOP` instruction isn't fully initialized. Hence, any > > parsing operations for it in handlers during `jit.dump()` leads to the > > "uninitialised value" error. This patch fixes the issue by the proper > > init of such IRs. > > Please add to a comment that with these tests the problem could > >  be reproduced: > > test/tarantool-tests/lj-1128-table-new-opt-tnew.test.lua > > test/tarantool-tests/fix-jit-dump-ir-conv.test.lua > > test/tarantool-tests/unit-jit-parse.test.lua Updated. The new commit message is the following: | Ensure full init of IR_NOP instructions. | | (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234) | | Before this patch, Valgrind produces tons of warnings during the VMevent | calls since the `IR_NOP` instruction isn't fully initialized. Hence, any | parsing operations for it in handlers during `jit.dump()` leads to the | "uninitialised value" error. | | This can be reproduced with the following tests from the | tarantool-tests suite: | * fix-jit-dump-ir-conv.test.lua | * lj-1128-table-new-opt-tnew.test.lua | * lj-981-folding-0.test.lua | * unit-jit-parse.test.lua | | This patch fixes the issue by the proper init of such IRs. | | Sergey Kaplun: | * added the description for the problem | | Needed for tarantool/tarantool#3705 | Part of tarantool/tarantool#10709 > > > > > Sergey Kaplun: > > * added the description for the problem > > > > Needed for tarantool/tarantool#3705 > > Part of tarantool/tarantool#10709 > > --- -- Best regards, Sergey Kaplun