From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2E1BAE02463; Fri, 6 Dec 2024 13:31:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2E1BAE02463 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1733481089; bh=KGeNbmlpi7G1SWS09SeAPR9QqQAFimUtMktRkiQhbdU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tnV48pzjI2WMQhIhzyQdaUBF+6Efli6iGT0MtCtQ5vB0nc7pnD6Fa+qBYys/48rKf F99VQk0Z6GPMjlbzhk3X1wt9J2kKUDDMd8s3FHWZHHoWsE/vFHXA6rzpfJpfjL79C2 O8BRKev86k5MTe7ez6nA4dX+BhHW7xP5UwJA7Jr4= Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 28339E02462 for ; Fri, 6 Dec 2024 13:31:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 28339E02462 Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aa6332dde13so187038866b.1 for ; Fri, 06 Dec 2024 02:31:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733481086; x=1734085886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bWVqt8BdCYXbzuK2l0ooBCu0u29EpebdbFNplB9U01s=; b=bRw3VV5bCd91U4fH20c/ATVGG1gTEZv/krJFrMYTlD7wH4e/+t8MPJBCT6Lq8/IHAW mRlOCBVHTe3Na2Dz1HvPbNGgJJgyVegq8tu4aBQIcLeNiKQoG86YuxrTfH5EOev80TT7 JcHhc4cpShs7hG4ZQo0rIF5E9WCxA9g85qfQ1pLG+sSp9Xlnqd0qWKhSFLO031z/bu4A Ooi0qslh7MxWcyeFQ4kpYYSxrurBij8th07S3WLnX7kAIhfELDUL0uwBlnJivJWe2Lr3 x7O6s+RDDEv8b4X9BkpZVnbzXCc/HgzQKNHG6pzsccMhHJgL7U/rKO0DEPfCl2W2fDpD zJOw== X-Forwarded-Encrypted: i=1; AJvYcCVDdDW1N5nzf7OK2n8NOrVE+bywJ2zyUe0g0ln75CwZbFq1zBFaF29KHoH1BQOb/IywRI+mAU5DYhEh30TizaJ9ow==@dev.tarantool.org X-Gm-Message-State: AOJu0Yx61FXecnnX9DAu9vIY2Sa0/fF2d5t6YH4+dnzvEAGAru7Soomc 9m+OOVg/Y27OV3kg+AZBfp6ngAqFKskiP/D1LUxxV4+M21uXQka5 X-Gm-Gg: ASbGncv9QHqzr7sfTSCiYTX2irEpFyRo9yVonFFzz0JLuHMDixSUMekrfAaSJ98l0Sm p9U9MAMmmm/onFSRW/dkJ5EyeGOondbwSpgSrM/1H0pN/kb7WjwhdIHIBIKh5AMk45MQqIzR0Sd V0vJD/kqgVXzoQxTLD6m2RjtMTZOCe948UXtN/BeD2uuexWxwF5npbgv8l7EYyCSbLKeufRELB3 LFtBo9sBWXj8j9aVH5Un4QSoiiDZj3DZxDIpeqjCf8xMA== X-Google-Smtp-Source: AGHT+IHDOVKpuxfjxn9Ta2FjiyfCyrN27tbofvxq9TyZFWdLXR1KBIzAiy7sSGH1NnMY3Q47fqVjVw== X-Received: by 2002:a17:907:7703:b0:aa5:46d3:4d88 with SMTP id a640c23a62f3a-aa639febbbfmr182782066b.15.1733481086031; Fri, 06 Dec 2024 02:31:26 -0800 (PST) Received: from localhost ([5.181.62.98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa62601f51csm221079966b.107.2024.12.06.02.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 02:31:25 -0800 (PST) X-Google-Original-From: Sergey Bronnikov Date: Fri, 6 Dec 2024 13:31:24 +0300 To: Sergey Kaplun Message-ID: References: <91c8ea2686bf2d89322d74b15dcd4eb8b8eb97f8.1733468484.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: X-Url: https://bronevichok.ru/ Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] test: skip sysprof tests with LUAJIT_DISABLE_SYSPROF X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey, fixes applied and force-pushed. On 11:08 Fri 06 Dec , Sergey Kaplun wrote: >Hi, Sergey! >Thanks for the patch! >LGTM, with a minor comment below. > >On 06.12.24, Sergey Bronnikov wrote: >> From: Sergey Bronnikov >> >> LuaJIT has a macro LUAJIT_DISABLE_SYSPROF that disable > >Typo: s/disable/disables/ Fixed. > >> sysprof support. Sysprof tests doesn't respect this macro > >Typo: s/doesn't/don't/ >Typo: s/macro/macro,/ Fixed. > >> and therefore some of them failed when macro is enabled. > >Typo: /macro/macro,/ Fixed as /macro/the macro/. > >> >> The proposed patch: > >This isn't proposed patch, but it is just patch, so: >s/proposed // > >> >> - skip sysprof testcases in a suite tarantool-c-tests > >Typo: /skip/Skips/ >Missed dot at the end of the sentence. Fixed. > >> - introduce an environment variable LUAJIT_DISABLE_SYSPROF in > >Typo: s/introduce/Introduces/ Fixed. > >> a suite tarantool-tests that set to 1 when sysprof support is > >Typo: s/set/is set/ Fixed. > >> disabled > >Missed dot at the end of the sentence. Fixed. > >> - propagate a status of sysprof support to Lua tests and skip > >Typo: s/propagate/Propagates Fixed. > >> testing when sysprof is disabled > >Missed dot at the end of the sentence. Fixed. > >> --- >> test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c | 4 ++++ >> test/tarantool-c-tests/misclib-sysprof-capi.test.c | 4 ++++ >> test/tarantool-tests/CMakeLists.txt | 4 ++++ >> test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua | 2 ++ >> .../profilers/gh-5813-resolving-of-c-symbols.test.lua | 2 ++ >> .../gh-7264-add-proto-trace-sysprof-default.test.lua | 2 ++ >> .../profilers/gh-9217-profile-parsers-error-handling.test.lua | 2 ++ >> test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 ++ >> 8 files changed, 22 insertions(+) >> >> diff --git a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c >> index a8de3358..de4fb2c4 100644 >> --- a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c >> +++ b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c >> @@ -277,8 +277,12 @@ static int test_tostring_call(void *ctx) >> >> int main(void) >> { >> +#if LUAJIT_DISABLE_SYSPROF >> + return skip_all("Sysprof is disabled (LUAJIT_DISABLE_SYSPROF)"); > >Minor: I suppose we can drop the LUAJIT_DISABLE_SYSPROF mentioning since >it becomes "maslo maslyanoe", for my taste. >Feel free to ignore. the intention was to describe a reason explicitly. Update skip message: diff --git a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c index de4fb2c4..a83a0921 100644 --- a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c +++ b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c @@ -278,7 +278,7 @@ static int test_tostring_call(void *ctx) int main(void) { #if LUAJIT_DISABLE_SYSPROF - return skip_all("Sysprof is disabled (LUAJIT_DISABLE_SYSPROF)"); + return skip_all("Sysprof is disabled"); #else /* LUAJIT_DISABLE_SYSPROF */ const struct test_unit tgroup[] = { test_unit_def(test_tostring_call), diff --git a/test/tarantool-c-tests/misclib-sysprof-capi.test.c b/test/tarantool-c-tests/misclib-sysprof-capi.test.c index ec3354cc..21e40d22 100644 --- a/test/tarantool-c-tests/misclib-sysprof-capi.test.c +++ b/test/tarantool-c-tests/misclib-sysprof-capi.test.c @@ -302,7 +302,7 @@ static int profile_func_jiton(void *test_state) int main(void) { #if LUAJIT_DISABLE_SYSPROF - return skip_all("Sysprof is disabled (LUAJIT_DISABLE_SYSPROF)"); + return skip_all("Sysprof is disabled"); #else /* LUAJIT_DISABLE_SYSPROF */ if (LUAJIT_OS != LUAJIT_OS_LINUX) return skip_all("Sysprof is implemented for Linux only"); diff --git a/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua b/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua index 379ccf8e..e3cb86c0 100644 --- a/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua +++ b/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua @@ -1,5 +1,4 @@ local tap = require('tap') -local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') local test = tap.test('gh-5688-tool-cli-flag'):skipcond({ ['Profile tools are implemented for x86_64 only'] = jit.arch ~= 'x86' and jit.arch ~= 'x64', @@ -8,7 +7,7 @@ local test = tap.test('gh-5688-tool-cli-flag'):skipcond({ ['No profile tools CLI option integration'] = _TARANTOOL, -- See also https://github.com/LuaJIT/LuaJIT/issues/606. ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), - ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, + ['Sysprof is disabled'] = os.getenv('LUAJIT_DISABLE_SYSPROF'), }) test:plan(3) diff --git a/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua index ff745225..4af1cf79 100644 --- a/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua +++ b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua @@ -1,12 +1,11 @@ local tap = require("tap") -local no_sysprof = os.getenv("LUAJIT_DISABLE_SYSPROF") local test = tap.test("gh-5813-resolving-of-c-symbols"):skipcond({ ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and jit.arch ~= "x64", ["Memprof is implemented for Linux only"] = jit.os ~= "Linux", -- See also https://github.com/LuaJIT/LuaJIT/issues/606. ["Disabled due to LuaJIT/LuaJIT#606"] = os.getenv("LUAJIT_TABLE_BUMP"), - ["Disabled due to LUAJIT_DISABLE_SYSPROF"] = no_sysprof, + ["Sysprof is disabled"] = os.getenv("LUAJIT_DISABLE_SYSPROF") }) test:plan(5) diff --git a/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua b/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua index e09016e7..0a909819 100644 --- a/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua +++ b/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua @@ -1,5 +1,4 @@ local tap = require('tap') -local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') local test = tap.test('gh-7264-add-proto-trace-sysprof-default'):skipcond({ ['Test requires JIT enabled'] = not jit.status(), ['Sysprof is implemented for x86_64 only'] = jit.arch ~= 'x86' and @@ -7,7 +6,7 @@ local test = tap.test('gh-7264-add-proto-trace-sysprof-default'):skipcond({ ['Sysprof is implemented for Linux only'] = jit.os ~= 'Linux', -- See also https://github.com/LuaJIT/LuaJIT/issues/606. ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), - ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, + ['Sysprof is disabled'] = os.getenv('LUAJIT_DISABLE_SYSPROF'), }) test:plan(2) diff --git a/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua b/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua index 012b1501..68c1b726 100644 --- a/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua +++ b/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua @@ -1,5 +1,4 @@ local tap = require('tap') -local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') local test = tap.test('gh-9217-profile-parsers-error-handling'):skipcond({ ['Profile tools are implemented for x86_64 only'] = jit.arch ~= 'x86' and jit.arch ~= 'x64', @@ -8,7 +7,7 @@ local test = tap.test('gh-9217-profile-parsers-error-handling'):skipcond({ ['No profile tools CLI option integration'] = _TARANTOOL, -- See also https://github.com/LuaJIT/LuaJIT/issues/606. ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), - ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, + ['Sysprof is disabled'] = os.getenv('LUAJIT_DISABLE_SYSPROF'), }) jit.off() diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua index ea5ca9a9..711ca646 100644 --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua @@ -1,12 +1,11 @@ local tap = require("tap") -local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') local test = tap.test("misc-sysprof-lapi"):skipcond({ ["Sysprof is implemented for x86_64 only"] = jit.arch ~= "x86" and jit.arch ~= "x64", ["Sysprof is implemented for Linux only"] = jit.os ~= "Linux", -- See also https://github.com/LuaJIT/LuaJIT/issues/606. ["Disabled due to LuaJIT/LuaJIT#606"] = os.getenv("LUAJIT_TABLE_BUMP"), - ["Disabled due to LUAJIT_DISABLE_SYSPROF"] = no_sysprof, + ["Sysprof is disabled"] = os.getenv('LUAJIT_DISABLE_SYSPROF'), }) test:plan(19) >> +#else /* LUAJIT_DISABLE_SYSPROF */ > > > >> diff --git a/test/tarantool-c-tests/misclib-sysprof-capi.test.c b/test/tarantool-c-tests/misclib-sysprof-capi.test.c >> index 6f53d488..ec3354cc 100644 >> --- a/test/tarantool-c-tests/misclib-sysprof-capi.test.c >> +++ b/test/tarantool-c-tests/misclib-sysprof-capi.test.c >> @@ -301,6 +301,9 @@ static int profile_func_jiton(void *test_state) >> >> int main(void) >> { >> +#if LUAJIT_DISABLE_SYSPROF >> + return skip_all("Sysprof is disabled (LUAJIT_DISABLE_SYSPROF)"); > >Ditto. > >> +#else /* LUAJIT_DISABLE_SYSPROF */ >> if (LUAJIT_OS != LUAJIT_OS_LINUX) >> return skip_all("Sysprof is implemented for Linux only"); >> if (LUAJIT_TARGET != LUAJIT_ARCH_X86 >> @@ -322,4 +325,5 @@ int main(void) >> const int test_result = test_run_group(tgroup, L); >> utils_lua_close(L); >> return test_result; >> +#endif /* LUAJIT_DISABLE_SYSPROF */ >> } >> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt >> index 8bdb2cf3..a6e39f6c 100644 >> --- a/test/tarantool-tests/CMakeLists.txt >> +++ b/test/tarantool-tests/CMakeLists.txt >> @@ -89,6 +89,10 @@ if(LUAJIT_ENABLE_TABLE_BUMP) >> list(APPEND LUA_TEST_ENV_MORE LUAJIT_TABLE_BUMP=1) >> endif() >> >> +if(LUAJIT_DISABLE_SYSPROF) >> + list(APPEND LUA_TEST_ENV_MORE LUAJIT_DISABLE_SYSPROF=1) >> +endif() >> + >> set(TEST_SUITE_NAME "tarantool-tests") >> >> # XXX: The call produces both test and target >> diff --git a/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua b/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua >> index f935dc5b..379ccf8e 100644 >> --- a/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua >> +++ b/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua >> @@ -1,4 +1,5 @@ >> local tap = require('tap') >> +local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') >> local test = tap.test('gh-5688-tool-cli-flag'):skipcond({ >> ['Profile tools are implemented for x86_64 only'] = jit.arch ~= 'x86' and >> jit.arch ~= 'x64', >> @@ -7,6 +8,7 @@ local test = tap.test('gh-5688-tool-cli-flag'):skipcond({ >> ['No profile tools CLI option integration'] = _TARANTOOL, >> -- See also https://github.com/LuaJIT/LuaJIT/issues/606. >> ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), >> + ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, > >Minor: "disabled due to disable" sounds like "maslo maslyanoe" for my >taste. I suppose "Sysprof is disabled" is just enough. As a minor bonus, >we may avoid the declaration of the `no_sysprof` variable since we can >just use one-line `os.getenv()` that fits into this line now. > >Same for the other Lua tests. Updated. > >> }) >> >> test:plan(3) >> diff --git a/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua >> index 74bcd9e8..ff745225 100644 >> --- a/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua >> +++ b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua >> @@ -1,10 +1,12 @@ >> local tap = require("tap") >> +local no_sysprof = os.getenv("LUAJIT_DISABLE_SYSPROF") >> local test = tap.test("gh-5813-resolving-of-c-symbols"):skipcond({ >> ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and >> jit.arch ~= "x64", >> ["Memprof is implemented for Linux only"] = jit.os ~= "Linux", >> -- See also https://github.com/LuaJIT/LuaJIT/issues/606. >> ["Disabled due to LuaJIT/LuaJIT#606"] = os.getenv("LUAJIT_TABLE_BUMP"), >> + ["Disabled due to LUAJIT_DISABLE_SYSPROF"] = no_sysprof, >> }) >> >> test:plan(5) >> diff --git a/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua b/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua >> index 176c1a15..e09016e7 100644 >> --- a/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua >> +++ b/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua >> @@ -1,4 +1,5 @@ >> local tap = require('tap') >> +local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') >> local test = tap.test('gh-7264-add-proto-trace-sysprof-default'):skipcond({ >> ['Test requires JIT enabled'] = not jit.status(), >> ['Sysprof is implemented for x86_64 only'] = jit.arch ~= 'x86' and >> @@ -6,6 +7,7 @@ local test = tap.test('gh-7264-add-proto-trace-sysprof-default'):skipcond({ >> ['Sysprof is implemented for Linux only'] = jit.os ~= 'Linux', >> -- See also https://github.com/LuaJIT/LuaJIT/issues/606. >> ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), >> + ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, >> }) >> >> test:plan(2) >> diff --git a/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua b/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua >> index 65c51198..012b1501 100644 >> --- a/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua >> +++ b/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua >> @@ -1,4 +1,5 @@ >> local tap = require('tap') >> +local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') >> local test = tap.test('gh-9217-profile-parsers-error-handling'):skipcond({ >> ['Profile tools are implemented for x86_64 only'] = jit.arch ~= 'x86' and >> jit.arch ~= 'x64', >> @@ -7,6 +8,7 @@ local test = tap.test('gh-9217-profile-parsers-error-handling'):skipcond({ >> ['No profile tools CLI option integration'] = _TARANTOOL, >> -- See also https://github.com/LuaJIT/LuaJIT/issues/606. >> ['Disabled due to LuaJIT/LuaJIT#606'] = os.getenv('LUAJIT_TABLE_BUMP'), >> + ['Disabled due to LUAJIT_DISABLE_SYSPROF'] = no_sysprof, >> }) >> >> jit.off() >> diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua >> index 26c277cd..ea5ca9a9 100644 >> --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua >> +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua >> @@ -1,10 +1,12 @@ >> local tap = require("tap") >> +local no_sysprof = os.getenv('LUAJIT_DISABLE_SYSPROF') >> local test = tap.test("misc-sysprof-lapi"):skipcond({ >> ["Sysprof is implemented for x86_64 only"] = jit.arch ~= "x86" and >> jit.arch ~= "x64", >> ["Sysprof is implemented for Linux only"] = jit.os ~= "Linux", >> -- See also https://github.com/LuaJIT/LuaJIT/issues/606. >> ["Disabled due to LuaJIT/LuaJIT#606"] = os.getenv("LUAJIT_TABLE_BUMP"), >> + ["Disabled due to LUAJIT_DISABLE_SYSPROF"] = no_sysprof, >> }) >> >> test:plan(19) >> -- >> 2.34.1 >> > >-- >Best regards, >Sergey Kaplun -- sergeyb@