From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8A409E0244D; Fri, 6 Dec 2024 13:16:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A409E0244D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1733480201; bh=zyfdamJGihZlvluBY45d6fFDFIV+UtAd69EGVFUJrOI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BUWjFurFY6Xt8X/1Bs+mdE5z9axZFlnQwy2EO/GCSbCeUtWIH0Z2VGM9tcK78nocZ tIhfXS7gXH6zcsMmObE0ClyaSy+yVr1qLtjy39PCf3XlmMaS6SaO01HwBsCqAcQ/rE mMHvu9gkI6b8u5I87QqujS4YKHiThnxJtNrYWNoE= Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CEA8F51C18F for ; Fri, 6 Dec 2024 13:16:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CEA8F51C18F Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3d2a30afcso154532a12.3 for ; Fri, 06 Dec 2024 02:16:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733480200; x=1734085000; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hwt44mnuet5SoBJbw+7yz7PgMv6WscxBSaAVXNyWFAw=; b=Qkdxtx6ZTS6W49FkWL5pt9Pyp/3LMIHj/8YppIu1QoKKrSIgwdSMUJlXI7PWL6aB6M /1nEOTaUvXg/j2H8i28ys9i5LTx6rjKIfJskl6dLtdxvg/ffToITIYu1+atFZz7eHSEg IsnMY9IsJTWIO60GEIn7/iCn+mLo0IrXxpKrCSiPPp/SGSSp+6Q0iv+3vy8WJQTvUOZv LOC2YG/gtzlTcp20zKS0E1lVvl8AZBeMrT4dhuNThf9TF4t3CgGo2u7MTkvYUWqEkZut eTdbOaDpE4JDosF6DIVB+7RTu6Acq1ufkl2FCDbovC55wm1sncX/BmlWRmjSdmDkNr3N OQnA== X-Forwarded-Encrypted: i=1; AJvYcCXIhLLw+3UjuhAglcYR6WHbs/stLf7eMPHL3wra6LcwQyWFgYLLd6U9/bHKPgpNfjW818tpeDnpc4/BUBxHY8WuDg==@dev.tarantool.org X-Gm-Message-State: AOJu0Ywn0jyt3k2LBxirXtVwFZ80ZICMcaC9YbrwEA14xf+dRDTT1sbC Mx8WfRRffJOkDk15ajpmsmQVmRL++pAWIZLs/r+J99ebMINGv6/U X-Gm-Gg: ASbGncvTTt1iccDlz+V7rfqiqXPCHPWFRGT1yZK7//iEGS7wYVR1wlybDIggUuH3vJl raX9av6NtVb6Mb/WrAppXAboZlru/lNhq8GqdS+hY2d1fhQ83R7NJJ1cuC+Erc5SrUEpxypPNTG tjI2s+hhTe2injdbrw4uDlcssnuqs2WEU9fW67S14YXWkS9Um/EUi2CKKD9Iq1lKA30Qq2e+kam WM/4wJYsD0S82OpTKG0omL1oUjY8tr+0QE6GLaumv1pqg== X-Google-Smtp-Source: AGHT+IFCWAr9yFnFxQLtbwAuqiaoj3ng1cLT6MO2NZ8f46C9/2vOqN9NcukxEd0jHn6d/beRtIOptA== X-Received: by 2002:a17:907:774d:b0:aa6:2567:efe8 with SMTP id a640c23a62f3a-aa639febf43mr227894866b.19.1733480199688; Fri, 06 Dec 2024 02:16:39 -0800 (PST) Received: from localhost ([5.181.62.98]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d14c798fbasm1963292a12.59.2024.12.06.02.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 02:16:39 -0800 (PST) X-Google-Original-From: Sergey Bronnikov Date: Fri, 6 Dec 2024 13:16:38 +0300 To: Sergey Kaplun Message-ID: References: <7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: X-Url: https://bronevichok.ru/ Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey, fixes applied and force-pushed. On 10:55 Fri 06 Dec , Sergey Kaplun wrote: >Hi, Sergey! >Thanks for the patch! >LGTM, with a few nits regarding the commit message. > >On 06.12.24, Sergey Bronnikov wrote: >> From: Sergey Bronnikov >> >> - fix a typo in a comment > >Typo? /fix/Fix/ >Typo? /comment/comment./ Fixed. > >> - replace `skip_all()` with `skip()` because it is strange > >Typo? /replace/Replace/ Fixed. > >> to skip overall test group inside a testcase. > >Typo: s/overall test group/the overall test group/ Fixed. > >> --- > > > > >-- >Best regards, >Sergey Kaplun -- sergeyb@