From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D706751C18F; Fri, 6 Dec 2024 10:56:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D706751C18F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1733471807; bh=5lPVE0DNMFgRCW0NmDXtQ11twDPfG9nMIZPtilFuoOQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=P68yUgbLvbKExc4fu8M0c3yzqMbZyul+VJeyMiMhjgcRhUSgwIsGHbhEG1qBzwLho jr8MYrpMZWp5WQ+Mw0+sTXM7j4qpswlHKzP8ZPps91+QWYQxY10ni4MjcAoIRPmyF/ 2Ylxr+MDbO32GKsMa/iw8bWMRRX9n8vfmFLmkGtQ= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0436151C18F for ; Fri, 6 Dec 2024 10:56:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0436151C18F Received: by exim-smtp-57cd6dcbd5-8hprr with esmtpa (envelope-from ) id 1tJTCe-00000000SPZ-0I6j; Fri, 06 Dec 2024 10:56:44 +0300 Date: Fri, 6 Dec 2024 10:55:49 +0300 To: Sergey Bronnikov Message-ID: References: <7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9008082F162C50007D325713A74BF3A1384DB9F88DFABA395182A05F5380850405E3F5A29A4C3117E3DE06ABAFEAF670537B629806355CB57B8E1BBE75FE31A38906DE0852CB23BE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C9074BA8BF974646F8ACA805B4E34DF4788752F0D76972610B9A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C37EF884183F8E4D67117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637427B078F297B269AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A53AEBA04D9E683A045002B1117B3ED696C7FA4792216FFF9E108A05421C070DB8823CB91A9FED034534781492E4B8EEAD0D89974173551D4FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF23A76072B63B96D4FC9C8B21BBA3F6FF73C5844D503639F090975F5B84794680715D154A38A044DC494E10A735AF7C93839303FC68F4C53EF02D3B7EDDDF502657A126E5F676196BC226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojOp8qHLJs/nSxaQawohhLCQ== X-DA7885C5: 99E9FAB9328E4D40F255D290C0D534F9F622EEF54D4F8C5B46B16E7FDE2A0FB16D832AE234183DB85B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA21927261FE3E1CB6BAC16211794EA841253B45FC078ABEA00DDE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, with a few nits regarding the commit message. On 06.12.24, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > - fix a typo in a comment Typo? /fix/Fix/ Typo? /comment/comment./ > - replace `skip_all()` with `skip()` because it is strange Typo? /replace/Replace/ > to skip overall test group inside a testcase. Typo: s/overall test group/the overall test group/ > --- -- Best regards, Sergey Kaplun