From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9DF76F3C8; Mon, 3 Oct 2022 14:11:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9DF76F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664795491; bh=A2KXx6IM1VocT5Q1Zl+W+Ufc2Wr+fwE92H1EABR0Xcw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V04QbG3hX2AxKelPLkd6epPvBXzSnAInaceeiTRk6A5ijybqNylVvwyFYqKpF4NkY VYzSsR062U2LL15jNZ+2+un6DwsxdcMjFgOzlKxxF1YV2LLAFbeepyUVJVvJ44hsIZ vmuPIuVL6O2kqWAYU2EFnuhWPOpzBBSmFZXfOEfw= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 34BF26F3C8 for ; Mon, 3 Oct 2022 14:11:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 34BF26F3C8 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1ofJM9-0007as-Fy; Mon, 03 Oct 2022 14:11:29 +0300 Date: Mon, 3 Oct 2022 14:08:37 +0300 To: Maksim Kokryashkin Message-ID: References: <1d15f0a9f3865b0ec374d66d01f38d055afc9eec.1664207262.git.max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d15f0a9f3865b0ec374d66d01f38d055afc9eec.1664207262.git.max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95BC634034C2E79655F6DA3E090DDED86EBB37F80958332E7182A05F538085040CB8FD8F4D83A075D90990697176DF2213A4B9461355F1D5DA7B68B2780FA6845 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75263010198C72082EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A69A378178A91E348638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86539DBA3B159BCBB2835BE609FFFD0C7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC09CDF8F23AD6196DA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEFAD5A440E159F97D96C9B5BF839F39F6D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252C6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0AB21DE2C0F4064F90E0E6A89656E61D34E9EFE114512EC148DEAC10E5F35F0649C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3430FC2BC1B917F018C339DF521A7D9BD734AB741DF4B3EC473303AC98BD43E1630D97809A2A5A8C9C1D7E09C32AA3244C56A8C12EC2FC667261B9B7869C73E21FD08D48398F32B4A6FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojf/9mtrlthuQaywkVet5IBQ== X-Mailru-Sender: 11ABF2DAD5F2676891056722DE4A719EF7000D21D2F4EBAE90990697176DF2210D95629463F16A6ADEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/6] OSX/ARM64: Disable external unwinding for now. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, with the several nits below. On 26.09.22, Maksim Kokryashkin wrote: > From: Mike Pall > > This reduces functionality, e.g. no handling of on-trace errors. > Someone with very deep knowledge about macOS and MACH-O/DWARF stack > unwinding internals is needed to fix this. See issue LuaJIT/LuaJIT#698. Side note: I'm not sure that we should mention the LuaJIT issues in our commit message -- every time you repush your branch, it adds another mention in upstream (you can check :)). That's definitely not what Mike wants :). Perhaps we should just mention the issue by number without a direct link to it. > > (cherry picked from commit 27ee3bcd79b12a0c71f00427ee1a2e486c684486) > > ARM64 interpreter doesn't have unwind info for Mach-O assembler > format, which makes unwinding impossible. > > For more info, see https://github.com/LuaJIT/LuaJIT/issues/698 Ditto. Nit: missed dot in the end of the sentence. > > Maxim Kokryashkin: > * added the description for the problem > > Needed for tarantool/tarantool#6096 > Needed for tarantool/tarantool#7230 Minor: s/Needed for/Part of/ > --- > cmake/SetTargetFlags.cmake | 4 +++- > src/Makefile.original | 5 ++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index a5a3407f..d99e1f9a 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > diff --git a/src/Makefile.original b/src/Makefile.original > index d1373b40..5826a56a 100644 > --- a/src/Makefile.original > +++ b/src/Makefile.original > -- > 2.32.1 (Apple Git-133) > -- Best regards, Sergey Kaplun