From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8DA576F3C8; Mon, 3 Oct 2022 13:57:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8DA576F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664794624; bh=d11SZUvwQhy7yohSiWJ9rJMDqTy3MY+dnRmhWTMa8T8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iMNBapCO85uz9FGxrPVTrtOwbjD2rqWtWpQ/GMZnrKJS86Kmw6tEtIWznUKObfuQb xm85fVv7KmhrgLTEgLTMQI3V0U93fHZAD1Y5nICTqwqaAL+8jydyaMINemuqcxWO0N XrQJ0tVdJQpLdEb7FdhTE2GffYcP/Cd/aBrh0nY0= Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 362576F3C8 for ; Mon, 3 Oct 2022 13:57:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 362576F3C8 Received: by smtp17.mail.ru with esmtpa (envelope-from ) id 1ofJ89-0004W4-Dn; Mon, 03 Oct 2022 13:57:02 +0300 Date: Mon, 3 Oct 2022 13:54:09 +0300 To: Maksim Kokryashkin Message-ID: References: <623a3c7c7aa9e8c5a2fdb68384c278825016f72e.1664207262.git.max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <623a3c7c7aa9e8c5a2fdb68384c278825016f72e.1664207262.git.max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95BC634034C2E7965DA83E3C469031EC888AB18343AB3162C182A05F5380850403E61F03D30892DC646103D2D626E8595A0C64FDDAC0EB397609FC6C4D9FE1DAA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE768BD42809A772457EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379C6642364E0E74208638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A4CCDD0D0D5676C8A81F4AFF22FCED0A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC899C4B0487787E7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0F1C9461EB66F04EBFD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE32A336C65186350912D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637FB177F6A8366F17BEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B06604ACF793451CC50E0E6A89656E61D3925C8BFD516561B72E470C59D365A4559C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF134889A7925BF60FA410D3EFD239A3C07379B841ED9BC5C9A738D36F31CE6B1D11D7E09C32AA3244CB65CA1E0C8C8880935DCD3E6745C50784DBEAD0ED6C55A80FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojf/9mtrlthuR+/m2VhipNDg== X-Mailru-Sender: 11ABF2DAD5F2676891056722DE4A719E5CE74D339FA8B99846103D2D626E85955F9045B74F665CC8DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/6] OSX: Fix build by hardcoding external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM with bunch of comments below. On 26.09.22, Maksim Kokryashkin wrote: > Apparently they can't even get 'grep' right, let alone a keyboard. > > (cherry picked from commit d4a554d6ee1507f7313641b26ed09bf1b518fa1f) > > MacOS uses BSD grep, which is slightly different from GNU grep. > Because of that, the shell script determining whether external > unwinding is possible doesn't work right. Nit: It detects, that unwinding is impossible, when it is possible actually. So we can mention here, that scripts yields false negative result for MacOS. > > External unwinding is possible on MacOS, so this patch enables I suggest to write here "always possible" to clarify the sentence. > it by default. > > Maxim Kokryashkin: > * added the description for the problem > > Needed for tarantool/tarantool#6096 > Needed for tarantool/tarantool#7230 I suggest to replace the line above with: | Part of tarantool/tarantool#7230 (Forgot to mention this in the previous patch, so it should be done for the previous commit too.) > --- > .github/workflows/macos-x86_64.yml | 20 +------------------- Looks like this fixes should be done in the previous commit. > cmake/SetTargetFlags.cmake | 28 ++++++++++++++++------------ > src/Makefile.original | 15 ++++++++------- > 3 files changed, 25 insertions(+), 38 deletions(-) > > diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml > index 840806e3..dafd1796 100644 > --- a/.github/workflows/macos-x86_64.yml > +++ b/.github/workflows/macos-x86_64.yml > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index 36896aff..a5a3407f 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > diff --git a/src/Makefile.original b/src/Makefile.original > index c9609700..d1373b40 100644 > --- a/src/Makefile.original > +++ b/src/Makefile.original > -- > 2.32.1 (Apple Git-133) > -- Best regards, Sergey Kaplun