From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 271996F3C8; Thu, 29 Sep 2022 16:11:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 271996F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664457099; bh=+Rri5FILXB6HCL6k3a/+Zo8lgZg8BTq2Ko1f4vPXCOA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TvnhmV0YwDNLDLkIBUp+MkRwk56Iy8pQFm0BT/vqdHNHGjwQZDjjzZCVQhRjt8Tuq Koo1G18JoitqqFLc93CR2ipmrOCtTrfWavPNbLWUkEaY1YJNlqtcOq92KZ2SpmiPbd DOHidFaFdwVxemyx3wjN56n+JTPVj5VmsT5DQmXE= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E36E6F3C8 for ; Thu, 29 Sep 2022 16:11:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E36E6F3C8 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1odtKA-0004OP-6N; Thu, 29 Sep 2022 16:11:36 +0300 Date: Thu, 29 Sep 2022 16:08:35 +0300 To: Maxim Kokryashkin Message-ID: References: <20220920111649.86190-1-max.kokryashkin@gmail.com> <4DD728DB-B92B-4466-A709-E3FD08576876@tarantool.org> <1664445487.810639758@f460.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1664445487.810639758@f460.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD99579AAB9113565745FAD1670205EF31196422286CE43C620182A05F5380850404C228DA9ACA6FE27F43E9CEB136C766BCF9D83E47FE830595CAAFB0BE7A6493FD0F85933A76E85ED X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E7A1B5661595F038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E334673A0569DECE019E860581CDD4EB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCD6672DD12D5A8206A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE38D4DC57D478E688CE99E4F20BAF2718D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D889735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CA6C7FFFE744CA7FB2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E62525E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0C7A0BC55FA0FE5FC8FF0AE163BA0B4CBF8199C71E4AF107E7EC741D65268D573B1881A6453793CE9C32612AADDFBE06133F7A9E5587C79A693EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34682FD2D2951524C567B4E06E19032230E8968224B7DD1D436FA6296A80C673E6D0C1ABFD9C1545A71D7E09C32AA3244C26216101156F184B0D079BCE35CEA96069B6CAE0477E908D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrN03fbmz7oavFExXHwT5MA== X-Mailru-Sender: 11ABF2DAD5F2676891056722DE4A719E4146F610037C40A0CF9D83E47FE83059B9A8FEFFB5F7F2D5DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] Fix narrowing of unary minus. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! LGTM, just a single nit below. On 29.09.22, Maxim Kokryashkin via Tarantool-patches wrote: > > Hi, Sergos! > Thanks for the questions! > Please consider my answers amd changes below. > Here is the diff: > =============================================== > --- a/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua > +++ b/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua > +test:ok(check(function() > +  -- See the comment about `table.new()` above. > +  local res = require('table.new')(3, 0) > +  for i = 2, 0, -1 do > +    table.insert(res, 1 / -i) > +  end > +  return res > +end),'assertion guard fail') Typo: s/,/, / >   > Best regards, > Maxim Kokryashkin >   -- Best regards, Sergey Kaplun