From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 200EF6F3C8; Wed, 21 Sep 2022 15:06:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 200EF6F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1663761961; bh=gABzkGIWdkIk/g0kCkZ9btJBMCTkrZqTjMODDTPagFg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=k+Hyr7fJN/IBtipDZRIj1MMGsjcv2MnvHTy80WSsUhGNbHt1DnQH0xYFEFqfi4noj GYG3iB1QMgApMeH9oqgCWNvSmMWxXx2zkX8fIl4o4emJ7uZA/3C84EZGREehhOH/3X gh+0TI2bDK839coOPJD2e7x2g0Wtx0I6yz0jSMc0= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C0F3E6F3C8 for ; Wed, 21 Sep 2022 15:05:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0F3E6F3C8 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1oayUJ-0004J7-2M; Wed, 21 Sep 2022 15:05:59 +0300 Date: Wed, 21 Sep 2022 15:03:15 +0300 To: sergos Message-ID: References: <20220912080158.12220-1-skaplun@tarantool.org> <1663573807.727706952@f769.i.mail.ru> <8E2BF2B3-C6BA-4F3E-A9AE-DA8F8413C4AF@tarantool.org> <1663667902.185627333@f160.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9EBD81B01C038F8F35C300DDA28984D43FE59DA0CD89D8E8E182A05F538085040A175A742DDB9E4FF2E0DAFFDDB6EE69E910B37FED62EBF47B2A8B4378A3E963E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE771540F9ECFC94C4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BC4B0F5721B555078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80E5C38EE4C1830626073A8B62945B066117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8883BAB8B32E402CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DE03CEA74F0D118906D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3CF7CD7A0D5AA5F2503F1AB874ED89028C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BF1C901A33650803EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B08B38D1BE91256DA74BE6EA2CDDC0A3E0B203A28C00D40D624F178F361D38BE879C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34505665BFD4C7070504CA644036C2A1E4088AD57B6389C4A6BEFACC33B3B337830B432F0E55786A1F1D7E09C32AA3244C0FD605733F0467F604D4DAE7CA533C9E853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojii4D+KDnlyoHGlz4/9cAGQ== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF094B98AC9D06E4F6730CA62D19D9734EB744E639442548C94F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Add tonumber() specialization for failed conversions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 20.09.22, sergos wrote: > First of all: > > s.ostanevich@s-ostanevich2:~/workspaces/t.sergos % uname -a > Darwin s-ostanevich2 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 > > Then I just built Tarantool with ninja: I tried run the test suite with ninja, but it's failed: | $ ninja -C build tarantool-tests | ... | /home/burii/builds_workspace/tarantool/master/third_party/luajit/test/tarantool-tests/lj-408.test.lua ...................................... | not ok - recorded with NULL and converted for 0LL | Dubious, test returned 1 (wstat 256, 0x100) | Failed 1/4 subtests |... | ninja: build stopped: subcommand failed. > > Tarantool 2.11.0-entrypoint-494-gdc147ec91 > Target: Darwin-x86_64-debug > > Then I brought the test as a patch from the mail and run ninja test. May you check the test output running without ninja like the follwing, please: | $ ../src/tarantool app-tap/lj-408-tonumber-cdata-record.test.lua | TAP version 13 | 1..4 | ok - recorded with NULL and not converted for NULL | not ok - recorded with NULL and converted for 0LL | --- | filename: app-tap/lj-408-tonumber-cdata-record.test.lua | line: 0 | trace: | - line: 0 | source: '@app-tap/lj-408-tonumber-cdata-record.test.lua' | filename: app-tap/lj-408-tonumber-cdata-record.test.lua | what: main | namewhat: | src: app-tap/lj-408-tonumber-cdata-record.test.lua | ... | ok - recorded with 0LL and converted for 0LL | ok - recorded with 0LL and not converted for NULL | # failed subtest: 1 Also, please, check `jit.dump()` output. Maybe there is not trace for some reason. You can run the following command: | $ ../src/tarantool -e 'require"jit.dump".start("ib")' app-tap/lj-408-tonumber-cdata-record.test.lua The start of output should be the following without the patch. | 1..4 | ---- TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17 | 0001 GGET 1 0 ; "tonumber" | 0002 MOV 2 0 | 0003 CALL 1 2 2 | 0000 . FUNCC ; tonumber | 0004 RET1 1 2 | ---- TRACE 1 IR | 0001 fun SLOAD #0 R | 0002 tab FLOAD 0001 func.env | 0003 int FLOAD 0002 tab.hmask | 0004 > int EQ 0003 +63 | 0005 p32 FLOAD 0002 tab.node | 0006 > p32 HREFK 0005 "tonumber" @8 | 0007 > fun HLOAD 0006 | 0008 > cdt SLOAD #1 T | 0009 > fun EQ 0007 tonumber | ---- TRACE 1 stop -> return | ... > > The output says the test passes, while sources contains no patch. Am I missing something? > > Sergos > > > > -- Best regards, Sergey Kaplun