From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2ABC6F15B; Tue, 23 Aug 2022 16:40:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2ABC6F15B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661262037; bh=U9ySgPXIlGmuDh+YYbPJIwkyXTYdaW2c/8fN86yVPj4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=uT02tK6jvArRdhEDpovMR/G5mMpNgGKn4eG+2lB84/IvAbGQTyrXDcvshkPFpnlrD aIgdN7WjKhobmx70RfsTOiyVHBpD4gMPHeCI8fFDQk+yoBwwwAMooRWtFrn2h/emQj /Ww+zC0XYa9d0hhXMEJG7t/8G4IPVIJu0u5bXLxk= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A6CD96F15B for ; Tue, 23 Aug 2022 16:40:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6CD96F15B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oQU8x-0007t6-23; Tue, 23 Aug 2022 16:40:35 +0300 Date: Tue, 23 Aug 2022 16:38:00 +0300 To: sergos Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Message-ID: References: <20220823080659.16880-1-skaplun@tarantool.org> <59F55FF8-96DB-4CB7-A689-87CAB607222C@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59F55FF8-96DB-4CB7-A689-87CAB607222C@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91FB0073BE751D55434A322C49FEE76FE366273BCDEC5D6D2182A05F538085040002389CB04135FF12E4A4E96036AD43396473C3A2D275CF89C7BCEA2493708FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7059B0D8AC717918AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374A24022C550661178638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8390DC4E11022F4D371F9DD1D75BC56E9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67ECBC18655D52CDF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0F56C66D0505D9834D9A1D0B5FC830B80B87C06BF378012F309BE339B8AAF780F9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34023CA4E4726A7D6CACC62EC8ABF04E573D5C4717E15EBD9DBC290FF80EB9FB9CA29A09AA4D20E1821D7E09C32AA3244C9115374EE8805DCA708843462CBE96FD6C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojzEOgLjt8B1oX4syHNEPOeQ== X-DA7885C5: C3C9E5A874937CE2673AA8AE3DD76249A2301D42B7DC430EEC13618BDC64B281262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E6BBF8EC3EA271A4A7590799B101645980FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix overflow check in unpack(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 23.08.22, sergos wrote: > Hi Sergey! > > Thanks for the patch, LGTM. > > Sergos. > > > > On 23 Aug 2022, at 11:06, Sergey Kaplun wrote: > > > > From: Mike Pall > > > > Thanks to HybridDog. Added the following forgotten title as usual:) | (cherry picked from commit 179cf2eb84fef2b9a524469c3c8cc49363b8fb10) Branch is force-pushed. > > > > When build with optimization compiler may throw away overflow check in > > `unpack()` base library function. > > > > This patch prevents aforementioned error by comparing the unsigned > > amount of values to unpack with `LUAI_MAXCSTACK` instead of 0. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#7230 > > --- > > > > Issue/PR: > > * https://github.com/LuaJIT/LuaJIT/pull/574 > > * https://github.com/tarantool/tarantool/issues/7230 > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-574-overflow-unpack-full-ci > > PR: https://github.com/tarantool/tarantool/pull/7596 > > > > 2.34.1 > > > -- Best regards, Sergey Kaplun