From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8D4916E444; Sat, 20 Aug 2022 09:28:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D4916E444 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1660976927; bh=qZEJ0N9oFBbO59fc3wZkULBtB5XL/jsyDsWUvfuv6bo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fzlfUa1bSvWBaC/mbRR39uMF8aLeKGs9jSiM/ZU8J++6oZwr7y37KT1XxVI+DoMdT 3daRNLDHM6pAjS4fWoKjwQN7w7Pu/Fq46jsLarF2UkbefZkxRahmgyqFEUJLLnOqCD EHZ9jOtb82xgsfPjaU5ZOq27oni5FcJ4/mX2AlV8= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 27E0C6E444 for ; Sat, 20 Aug 2022 09:28:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 27E0C6E444 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1oPHyP-0004V9-3E; Sat, 20 Aug 2022 09:28:45 +0300 Date: Sat, 20 Aug 2022 09:26:11 +0300 To: Mikhail Elhimov Message-ID: References: <9eaffd397e8ebb3ccb898d50686249b9edd3f02f.1658531255.git.m.elhimov@vk.team> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9eaffd397e8ebb3ccb898d50686249b9edd3f02f.1658531255.git.m.elhimov@vk.team> X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD999D8F08CF16C6CA7B75BF48E027C7DFE4E81F9F80E2FA7C500894C459B0CD1B9A6EB923A4D63C46FAEFB03D1F58513799B1E9161F100813500C9DE52C14C3926 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8162C7012605A763347B9E50A86540B30117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE96A3A8AAADC8934A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67ECBC18655D52CDF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0C7A0BC55FA0FE5FCE9A6EC5466BFFC98B6DF835B7E9B59C3ABAB736D75EEE878B1881A6453793CE9C32612AADDFBE06133F7A9E5587C79A693EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346EDE9E12965E8CD5F78F72404A511A4F4B1C98887E11E9FD2F94EC427E2FBDB291022DC08588ABD61D7E09C32AA3244CBCE281FA5CADB9EA25038E9A7C5F4EB6F522A1CF68F4BE05FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojsjCIxnYhpZN4ue5nO0e3yg== X-DA7885C5: B7F8FA501E9389D67BA5F1968D7483E89FDED7F1D337F173C8E81D77AD82A2B4262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EB7001CE266EB5A15B0A270439E2D71D50FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] gdb: adjust to support python2 (centos 7) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Mikhail! Thanks for the patch! Sorry, for such long waiting. It's LGTM, except a few stylish comments regarding the commit message. On 23.07.22, Mikhail Elhimov via Tarantool-patches wrote: > Stop using unpacking arguments within list initialization as python2 Typo: s/list initialization/the list initialization/ Also, you may mention that this problem affected Lua stack dump. > only supports it in function call Typo: s/function call/a function call/ Missed dot at the end of the sentence. > > fixes tarantool/luajit#7458 Typo: Fixes tarantool/tarantool#7458 > --- > src/luajit-gdb.py | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index baf66f66..1e9a96fb 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > -- > 2.34.1 > -- Best regards, Sergey Kaplun