From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 852BF6F153; Wed, 31 Aug 2022 18:17:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 852BF6F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661959061; bh=9j5/kE0XKEmcbK3TuhyDSz9CpyGLd5JzCzFPO6Gtdg4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g6HyUnzpyekW/tqw+3IwlCBj7d7XVVkHjY3AkUmhF9ycvR/OyhjPRulAeLgNGZwmB EgJ/oCXb3SrrN6vVr2Gv/ZKnZLyr6Vh7/QU70zMxufLsD0ME12gmfRlVqnpGCaOFYs pRvDFnf0hNihU1CaZNrSyrtCN3dP/LUhx29M+3Gg= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3C4516F153 for ; Wed, 31 Aug 2022 18:17:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C4516F153 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1oTPTH-0008K8-GH; Wed, 31 Aug 2022 18:17:39 +0300 Date: Wed, 31 Aug 2022 18:07:22 +0300 To: Sergey Bronnikov Message-ID: References: <1d05bbecc9c9ae57250ec563e202a8e103f86fa4.1660216002.git.imun@tarantool.org> <43afa059-82e9-422e-2636-f063bba9f847@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43afa059-82e9-422e-2636-f063bba9f847@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9BF9AC82A1D2D7237ECC9B9481A4CD7BD50746863994A0877182A05F53808504075D92C64C46E5D96BA015095207C61C15B813B8E5DD6FFB485A272B0C18CACFF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE761966F250AC1AE21EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BAF11BF3F55B41C6FE6CF29BC27FFABCE9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D028CC0B556B22BCC4224003CC83647689D4C264860C145E X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0C7A0BC55FA0FE5FC6D0EF893F092BBEAB7A6A7CBB41A61EBAE97E5619F6B9BF5B1881A6453793CE9C32612AADDFBE06133F7A9E5587C79A693EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F804B400765FFFF944723D7C14F5D8F2A0457F1235300017745C9AF2C5AFD4908A8DB41543B3E3801D7E09C32AA3244C4204DA8C207CB628EF17DFAABCC767333A92A9747B6CC886927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxzT94hBWyporVpD1Q+LHmw== X-DA7885C5: 5782EC78B5DA3408040C3E02EAE146282B942F0CE15ABABDB32A70D5434F4310262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E21E3F26D84D6F410C86AE52D4F0CD1DFA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for you review! On 15.08.22, Sergey Bronnikov wrote: > Igor, thanks for the patch! See my comments inline. > > On 11.08.2022 14:17, Igor Munkin wrote: > > While extending test suites it is often required to append additional > > path where Lua or Lua-C auxiliary modules are located to LUA_PATH or > > LUA_CPATH environment variables. Due to insane semicolon interpolation > > in CMake strings (that converts such string to a list as a result), we > > need to escape semicolon in LUA_PATH/LUA_CPATH strings while building > > the resulting value. > > > > After the years of struggling MakeLuaPath.cmake module is introduced to > > make LUA_PATH and LUA_CPATH definition convenient with > > helper. This function takes all paths given as a variable list argument, > > joins them in a reverse order by a semicolon and yields the resulting > > string to a specified CMake variable. > > > > Signed-off-by: Igor Munkin > > --- > > cmake/MakeLuaPath.cmake | 46 +++++++++++++++++++++++ > > test/CMakeLists.txt | 2 + > > test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 8 +++- > > test/lua-Harness-tests/CMakeLists.txt | 16 +++++--- > > test/tarantool-tests/CMakeLists.txt | 28 ++++++++------ > > 5 files changed, 81 insertions(+), 19 deletions(-) > > create mode 100644 cmake/MakeLuaPath.cmake > > > > diff --git a/cmake/MakeLuaPath.cmake b/cmake/MakeLuaPath.cmake > > new file mode 100644 > > index 00000000..9a5a3bb8 > > --- /dev/null > > +++ b/cmake/MakeLuaPath.cmake > > + > > + # FIXME: if we update to CMake >= 3.5, can remove this line. > > I would replace comment with condition that will check CMake version > > and will fail when CMake >= 3.5: > > |if (CMAKE_VERSION VERSION_GREATER_EQUAL 35) | > >    message(FATAL_ERROR "Please remove snippet for CMake < 3.5") > > endif() I doubt this is a working solution. The comment means, that there is no need to include a separate module if CMake to be used is greater than 3.5. With your code, fatal error is raised in that case. I have CMake 3.20 on my local machine and LuaJIT fails to be built with your check added (I've fixed the typo in the version number). Ignoring for now. > > > > + include(CMakeParseArguments) -- Best regards, IM