From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8541C6F153; Wed, 31 Aug 2022 17:57:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8541C6F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661957856; bh=tT9W9T8iRI7wwgFZilale5JdpO+NV2jccyO+AllB6Oo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=slCRg6YLl979wMJ12M+f2IymOfywch629hiQyhuKkxOdahRXH5BtiAC1gyAx/xx8I Vl16zXDbNkSz/HRzEAgSspzDGrewa0PXZWLmqi/xGOTNXtnEqAKXQA0Zb8CIPCMHg+ m+w8ftGuwnMIlcAdffkz4afgKmD4m3V/0bCJBDTc= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0DC656F153 for ; Wed, 31 Aug 2022 17:57:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0DC656F153 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oTP9q-0005XR-5T; Wed, 31 Aug 2022 17:57:34 +0300 Date: Wed, 31 Aug 2022 17:47:16 +0300 To: Mikhail Elhimov Message-ID: References: <9eaffd397e8ebb3ccb898d50686249b9edd3f02f.1658531255.git.m.elhimov@vk.team> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9eaffd397e8ebb3ccb898d50686249b9edd3f02f.1658531255.git.m.elhimov@vk.team> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9BF9AC82A1D2D7237348FBDDF4BD7B3F5AB3D3A126D7E1DA2182A05F5380850406D7C903193ED6D75864823FCD3900E81F03DA2EA7FBC4C6AD430718C096838CA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78C722B68A3D10D1CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376AFB9B40001E44068638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D858F03B5B86887A338C488C2FB131FAE6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B6FC43C45D3E35E8FA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C4FDA232B6711D9E343847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0C7A0BC55FA0FE5FC6D0EF893F092BBEA9CEE63553D65B6DC421E7FEBBB46114BB1881A6453793CE9C32612AADDFBE06133F7A9E5587C79A693EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34ECB3E21D3CD9CB4F9DF595150ED2B7737A08FF70E90D3FAC72F3E18523EDBBF2C2158991E4BB7F431D7E09C32AA3244C5F79FCD59F09E3457A3C3AAC3FCAFDD3F165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxzT94hBWypp4iubiwrS1AQ== X-DA7885C5: C22CE4EAAA6D82554181CD27C10B8267ED3C950AF92DD4E1FA1AD3643EF5A11C262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EC13ADA09B1FEEC3FD58358EB95E270CAA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] gdb: adjust to support python2 (centos 7) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, Thanks for the patch! Almost LGTM after your fixes for Sergey comments: please, consider the last nit, I found. On 23.07.22, Mikhail Elhimov via Tarantool-patches wrote: > Stop using unpacking arguments within list initialization as python2 > only supports it in function call > > fixes tarantool/luajit#7458 > --- > src/luajit-gdb.py | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index baf66f66..1e9a96fb 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -432,15 +432,16 @@ def dump_stack(L, base=None, top=None): > maxstack = mref('TValue *', L['maxstack']) > red = 5 + 2 * LJ_FR2 > > - dump = '\n'.join([ > - '{padding} Red zone: {nredslots: >2} slots {padding}'.format( > - padding = '-' * len(PADDING), > - nredslots = red, > - ), > - *( > - dump_stack_slot(L, maxstack + offset, base, top, '') > - for offset in range(red, 0, -1) > - ), > + dump = [] Please move this line to the "definition" section above to save the original structure. > + dump.append('{padding} Red zone: {nredslots: >2} slots {padding}'.format( > + padding = '-' * len(PADDING), > + nredslots = red, > + )) > + dump.extend([ > + dump_stack_slot(L, maxstack + offset, base, top, '') > + for offset in range(red, 0, -1) > + ]) > + dump.extend([ > '{padding} Stack: {nstackslots: >5} slots {padding}'.format( > padding = '-' * len(PADDING), > nstackslots = int((tou64(maxstack) - tou64(stack)) >> 3), > @@ -451,7 +452,8 @@ def dump_stack(L, base=None, top=None): > end = strx64(maxstack - 1), > nfreeslots = int((tou64(maxstack) - tou64(top) - 8) >> 3), > ), > - ]) + '\n' > + ]) > + dump = '\n'.join(dump) + '\n' > > slot = top > framelink = base - (1 + LJ_FR2) > -- > 2.34.1 > -- Best regards, IM