From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5B1936F153; Wed, 31 Aug 2022 18:44:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B1936F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661960643; bh=6Fx29ZukPOiC0+P/B4/lbxlfNzuXYH4yJughHAbt990=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZAhVomAy82s4AHcnXuca6wrfU5X4h2RZvdsjX9IN1B1KGSShh7i4xuk+SYRQBJoru 38VmeubP5/ectjDDJaIrQrCi010Jxpwrc5/A36D/4tejrhx0xeiKeJgVYVlLNZc9c7 a07eqS+zIgiHv2a4W2yU09i658mm9Vs9uu8RD4Qg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 97A166F153 for ; Wed, 31 Aug 2022 18:44:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 97A166F153 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oTPsm-0004cG-HK; Wed, 31 Aug 2022 18:44:01 +0300 Date: Wed, 31 Aug 2022 18:33:43 +0300 To: Sergey Bronnikov Message-ID: References: <9d4258549598fa5c11a4da1a40ca50cbb6281a16.1660216002.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BF9AC82A1D2D7237C715F2A45B0E0EEA7EC5A059D0CC026E182A05F538085040485D26C4555451F9EBB222F90A6A781DAA9AAB88C71E159143FD97FB4810D1B8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CF4D16325FBE1EEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EADD4AAB1147FEDD6C47EB277F119EC0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C5C8BF3F796D5A11743847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0CEC15DA3DDAC9727523897933F9F8387A394F2003BF07334A2651823CCBB143E9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D4140D813EC137C65702DEE2761AD76461B8F460244E7BFFE7F9C8FA72DD149FE82E757513FBA2861D7E09C32AA3244CE27B75686333AD30B58BBA5E36EC3E9755E75C8D0ED9F6EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxzT94hBWypqeUHtz8andog== X-DA7885C5: B40DE921EEE8B7307033E0BB319A2A8084EAAE1B90E0F203DDF78E28A1EFE1FF262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E8EE41D8BC1C7A69D254D6C02952D3E9EA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 15.08.22, Sergey Bronnikov wrote: > Igor, please see my comment below. > > On 11.08.2022 14:17, Igor Munkin wrote: > > Use out of source build configuration for LuaJIT testing jobs in all > > GitHub workflows. For this build type configuration unique subdirectory > > (using GitHub run ID) within runner temporary directory is used as a > > binary artefacts tree. > > > > Signed-off-by: Igor Munkin > > --- > > .github/actions/environment/action.yml | 5 +++++ > > .github/workflows/lint.yml | 3 ++- > > .github/workflows/linux-aarch64.yml | 6 +++++- > > .github/workflows/linux-x86_64-ninja.yml | 6 +++++- > > .github/workflows/linux-x86_64.yml | 7 ++++++- > > .github/workflows/macos-m1.yml | 6 +++++- > > .github/workflows/macos-x86_64.yml | 7 ++++++- > > 7 files changed, 34 insertions(+), 6 deletions(-) > > > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > > index 8c8dcff1..21d86764 100644 > > --- a/.github/workflows/linux-aarch64.yml > > +++ b/.github/workflows/linux-aarch64.yml > > @@ -53,11 +53,15 @@ jobs: > > sudo apt -y update > > sudo apt -y install cmake gcc make perl > > - name: configure > > - run: cmake . ${{ matrix.CMAKEFLAGS }} > > + run: > > > + cmake -S . -B ${{ env.BUILDDIR }} > > + ${{ matrix.CMAKEFLAGS }} > > - name: build > > run: cmake --build . --parallel > > + working-directory: ${{ env.BUILDDIR }} > > - name: test > > run: cmake --build . --parallel --target test > > + working-directory: ${{ env.BUILDDIR }} > > 1. I don't get an idea to use current dir for CMake and specify a > working-directory in a job step. > > Why not "cmake --build ${{ env.BUILDDIR }}" as above? I tried to not touch the original command. Configuration step can't be left intact, but build and test -- can and that makes diff more clear (IMHO). Furhermore, it looks more explicit to me: the command is run in the current directory, and the current directory is specified separately from the command itself. > > > > > test-tarantool-debug-w-GC64: > > name: Tarantool Debug GC64:ON -- Best regards, IM