From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6CA7B6F153; Wed, 31 Aug 2022 19:12:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CA7B6F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661962346; bh=nRpswTh1hI8L2ZZAkHbdEExwptistHZiH96BLl+jSm8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lFoe2rcYggbe+zp/zt4I3KKDSBhq3ViCu2trPQudJ6CGyZOnEZGfFAMXY+WKT6nkW gxZ/+I1Ala+ksGTWCK++PhdpX96/xGRtL0HplBsNE9cRQu2TAQNfLII0+3+3NaOjGY ptM357ziNwgDzgSxZ1hbb8CcdYDRT9SA+mJbJ/Xg= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C95526F153 for ; Wed, 31 Aug 2022 19:12:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C95526F153 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1oTQKF-00057A-OY; Wed, 31 Aug 2022 19:12:24 +0300 Date: Wed, 31 Aug 2022 19:02:06 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9BF9AC82A1D2D72376AD1D50FE522166510756AD903D3B97E182A05F538085040FBBE01908487608675CC2B44A1CB127500D837592F852B44ADEBEAC9A2763A09 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D05773942AAE9CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8699EA3581F49EA8D53C3FB325594AB1E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CE0F3BA37685B2B9043847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0D4C601CEA03E70EE523897933F9F8387BB15F114D55ADC87DC0F49B00F26CD499C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34431D0341F6B74DD3EC6E203C52F6BDC995AF3BA499E12869F97B921516891C833CBE7160A62E08841D7E09C32AA3244CD55CF5EC2B1E116F35F3305C8CF03F449CA7333006C390A0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxzT94hBWypoLjkaDTGGHEg== X-DA7885C5: FB633A4044AC39957AE7BE70BB93174B97A970262BBE53FA1F206265A8C697F9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E87D7547E690231D3D05D4EF266006FBEA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 18.08.22, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM! > > On 11.08.22, Igor Munkin wrote: > > As a result of the previous commit, there is no difference left between > > x86_64 and ARM64 workflows except the runner where workflow is run. > > Hence there is no reason to have a separate workflow file for each > > hardware architecture. > > > > Signed-off-by: Igor Munkin > > --- > > .github/workflows/linux-aarch64.yml | 83 ----------------- > > .../workflows/{linux-x86_64.yml => linux.yml} | 52 ++++++++--- > > .github/workflows/macos-m1.yml | 92 ------------------- > > .../workflows/{macos-x86_64.yml => macos.yml} | 52 ++++++++--- > > 4 files changed, 82 insertions(+), 197 deletions(-) > > delete mode 100644 .github/workflows/linux-aarch64.yml > > rename .github/workflows/{linux-x86_64.yml => linux.yml} (69%) > > delete mode 100644 .github/workflows/macos-m1.yml > > rename .github/workflows/{macos-x86_64.yml => macos.yml} (73%) > > > > @@ -65,8 +77,8 @@ jobs: > > run: cmake --build . --parallel --target test > > working-directory: ${{ env.BUILDDIR }} > > > > - test-tarantool-debug-wo-GC64: > > - name: Tarantool Debug GC64:OFF > > + test-tarantool-x86_64-debug-wo-GC64: > > Side note: Can we use the same matrix approach for integration > workflows? Unfortunately, we can't: reusable workflows doesn't support matrix approach (as I've already mentioned here[1]). > > > + name: Tarantool x86_64 Debug GC64:OFF > > needs: test-luajit > > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > > with: > > -- > > 2.34.0 > > > > -- > Best regards, > Sergey Kaplun [1]: https://lists.tarantool.org/tarantool-patches/YrzPiTa7FyNFKbbW@tarantool.org/ -- Best regards, IM