From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5AD2B6F153; Wed, 31 Aug 2022 19:05:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5AD2B6F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661961946; bh=zChmFwfOmStqHQgBSyz/fpgKlbyEU1I6v+mxMtbTXkw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ffw594M1OPk8uxiyngUQvASZtlzVixUVrkq6HZ8lkY+elZDY7IbaFO71yLod/JmCL GAMvom41g/caSE4FgrnN2/9L7qAUI4wi+gRhXLo0nD9OKRaAPBrhLbyoWwAyG0u3mK Z4B9CAwEq4YGGpWdbntrxeV5PP4fyAlRPXGzNq0M= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1AD1D6F153 for ; Wed, 31 Aug 2022 19:05:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1AD1D6F153 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oTQDo-0003H5-5j; Wed, 31 Aug 2022 19:05:44 +0300 Date: Wed, 31 Aug 2022 18:55:27 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BF9AC82A1D2D72373D7B6BD1783EF43F26EE5E824BBE481C182A05F538085040EF69FB54AE8D529F3BED698F5694E9C1E124B65D140ACCC81BC8FEE65C3DB9A4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BA5BFA4E020A0344884D42D071EED374117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B47272755C61AA17BA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CE0F3BA37685B2B9043847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0D4C601CEA03E70EE523897933F9F838724E5ABB293C2E0D520680AD6222444899C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349A949488F6BF46DD90827C04902F714453FBAB56C26E5081CD9E378A79D4EA98ED783A28877F20FB1D7E09C32AA3244C1306DC4E6D44BECF9239D95A15F5D7DF1E098CBE561D6343927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxzT94hBWyppOvUlGk7LxIw== X-DA7885C5: E2276627F921453E58F5109F21EA353693B8CEF5985C1A20DDCEE7AF98C07B44262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E5DF4158CBFAE0D3A18E04CB0165D7E02A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! I've fixed all your comments, see the new commit message at the bottom. On 18.08.22, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a single nit regarding the commit message. > > On 11.08.22, Igor Munkin wrote: > > Finally self-hosted GitHub Actions runners support Apple M1 hardware. As > > Side note: Is there any link or an announcement of it? Added. > > > a result there is no need to explicitly add `arch -arm64` prefix for all > > Typo: s/As a result/As a result,/ Fixed. > > > commands being run in scope of macOS M1 workflows. > > > > Signed-off-by: Igor Munkin > > --- > > .github/workflows/macos-m1.yml | 19 +++++++------------ > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > > index d5b0e0f1..4e1275f7 100644 > > --- a/.github/workflows/macos-m1.yml > > +++ b/.github/workflows/macos-m1.yml > > > > > -- > > 2.34.0 > > > > -- > Best regards, > Sergey Kaplun | ci: remove arch prefix for macOS M1 workflow | | Finally self-hosted GitHub Actions runners support Apple M1 hardware[1]. | As a result, there is no need to explicitly add `arch -arm64` prefix for | all commands being run in scope of macOS M1 workflows. | | [1]: https://github.blog/changelog/2022-08-09-github-actions-self-hosted-runners-now-support-apple-m1-hardware/ -- Best regards, IM