From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A0B2B6F158; Thu, 18 Aug 2022 13:24:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A0B2B6F158 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1660818248; bh=qzBe5133saBMk1wI0p5nKarEFGBABLuZlXFDy4E24dQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZfFkYBZYiXpIsnxiq+xjY0ZV9NypbIs0n0yxw2P8ZmPLMzf0nOGE8YRTDVqIES3hR k7aSdbbtP/2wSGXpHBdu7MaMm9Fr5uP2AfFsJ3otDWynqwmtPwCF+MCeOgmSnMIM+g f2kUu/YaU9YhjQf1pw/6ysisT9tp8rWiOqGxAp2E= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EC5D16F158 for ; Thu, 18 Aug 2022 13:24:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC5D16F158 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oOch5-0002u3-6I; Thu, 18 Aug 2022 13:24:07 +0300 Date: Thu, 18 Aug 2022 13:21:34 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD999D8F08CF16C6CA74956D63C129D917351CC51FE07055ADC00894C459B0CD1B920954B3A5B52E446A6A51AC5CB0FCD48AF222FE4A98A81E9386F63046B3269FA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71B1B5393BB9C1313EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE4B4B08BC34B6C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8944A2E76C74B08A624C5F0033B8CBA79117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAB5495298CADBD05A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209ECD01F8117BC8BEA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CC415C329B279CF9D43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0C7A0BC55FA0FE5FCD2D2979CC2033334C7B7A08D851ECAACB9004F413A9DE0B0B1881A6453793CE9C32612AADDFBE06133F7A9E5587C79A693EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3438BC6CF312DA7315D1A4AA173609F417DE514A0311E36AE30FAED1CD45A79862E03697E822CA07841D7E09C32AA3244C429CF5F0FCF34B542442F63EBA86BD7D81560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7Jv35gwMd2OxesVm1XWQcQ== X-DA7885C5: D85A923112A10C73C459B06E6CAEEB0C0C20B1EC2D3518457D3D15805E8BA05E262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EB7115ED648E45057C5E7AD97B14E855F0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM! On 11.08.22, Igor Munkin wrote: > As a result of the previous commit, there is no difference left between > x86_64 and ARM64 workflows except the runner where workflow is run. > Hence there is no reason to have a separate workflow file for each > hardware architecture. > > Signed-off-by: Igor Munkin > --- > .github/workflows/linux-aarch64.yml | 83 ----------------- > .../workflows/{linux-x86_64.yml => linux.yml} | 52 ++++++++--- > .github/workflows/macos-m1.yml | 92 ------------------- > .../workflows/{macos-x86_64.yml => macos.yml} | 52 ++++++++--- > 4 files changed, 82 insertions(+), 197 deletions(-) > delete mode 100644 .github/workflows/linux-aarch64.yml > rename .github/workflows/{linux-x86_64.yml => linux.yml} (69%) > delete mode 100644 .github/workflows/macos-m1.yml > rename .github/workflows/{macos-x86_64.yml => macos.yml} (73%) > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > deleted file mode 100644 > index 21d86764..00000000 > --- a/.github/workflows/linux-aarch64.yml > +++ /dev/null > @@ -1,83 +0,0 @@ > diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux.yml > similarity index 69% > rename from .github/workflows/linux-x86_64.yml > rename to .github/workflows/linux.yml > index 4c3ad4c7..125c8708 100644 > --- a/.github/workflows/linux-x86_64.yml > +++ b/.github/workflows/linux.yml > @@ -65,8 +77,8 @@ jobs: > run: cmake --build . --parallel --target test > working-directory: ${{ env.BUILDDIR }} > > - test-tarantool-debug-wo-GC64: > - name: Tarantool Debug GC64:OFF > + test-tarantool-x86_64-debug-wo-GC64: Side note: Can we use the same matrix approach for integration workflows? > + name: Tarantool x86_64 Debug GC64:OFF > needs: test-luajit > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > with: > @@ -74,8 +86,8 @@ jobs: > buildtype: Debug > host: ubuntu-20.04-self-hosted > revision: ${{ github.sha }} > - test-tarantool-debug-w-GC64: > - name: Tarantool Debug GC64:ON > + test-tarantool-x86_64-debug-w-GC64: > + name: Tarantool x86_64 Debug GC64:ON > needs: test-luajit > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > with: > @@ -83,8 +95,8 @@ jobs: > buildtype: Debug > host: ubuntu-20.04-self-hosted > revision: ${{ github.sha }} > - test-tarantool-release-wo-GC64: > - name: Tarantool Release GC64:OFF > + test-tarantool-x86_64-release-wo-GC64: > + name: Tarantool x86_64 Release GC64:OFF > needs: test-luajit > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > with: > @@ -92,8 +104,8 @@ jobs: > buildtype: RelWithDebInfo > host: ubuntu-20.04-self-hosted > revision: ${{ github.sha }} > - test-tarantool-release-w-GC64: > - name: Tarantool Release GC64:ON > + test-tarantool-x86_64-release-w-GC64: > + name: Tarantool x86_64 Release GC64:ON > needs: test-luajit > uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > with: > @@ -101,3 +113,21 @@ jobs: > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > deleted file mode 100644 > index 4e1275f7..00000000 > --- a/.github/workflows/macos-m1.yml > +++ /dev/null > @@ -1,92 +0,0 @@ > -- > 2.34.0 > -- Best regards, Sergey Kaplun