From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 87F076F158; Thu, 18 Aug 2022 13:01:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87F076F158 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1660816869; bh=rjfCGI2g7HpJzSnTehFxobNtrzTO5rHD61MLtUyw33Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZpLoQflEwh+C9dsekZSNpIP7toYq+9ZvqTk7Pv470V2/O32pw9JmbpVyn6OsCsSKp 2RDECwhOTEcw9k5uS6Hn9SqiXxPs6iALPOPkcOdp+FAaEiZbrWsnTCVkhUGGF+lGEH FYolgDcknpawyX5x+sNtymrJMQvYg/h40fEDn3lQ= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9BBE76F158 for ; Thu, 18 Aug 2022 13:01:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9BBE76F158 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1oOcKp-00026U-RQ; Thu, 18 Aug 2022 13:01:08 +0300 Date: Thu, 18 Aug 2022 12:58:35 +0300 To: Sergey Bronnikov Message-ID: References: <9d4258549598fa5c11a4da1a40ca50cbb6281a16.1660216002.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD999D8F08CF16C6CA71DBD9C3FAC4D955E2B144A54E1E1C57300894C459B0CD1B97911274C6B8ECEF3B6DF68EC368A274D3A25CB8FAC4E1075D8331305C3D564B6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6A43EB42C8B28B9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378F586D843116CFB2EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BA9804E0E6E629879C998505194A0808F3CC7F00164DA146DAFE8445B8C89999728AA50765F7900637A359038F01FFAF82389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B851EDB9C5A93305EEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0D4C601CEA03E70EE95B05B7676B1EE85B406B4C814485211D627CEC2847A740B9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341ADA1A41A420E9B227E00FB3D3CBB9BD8A90C6283149EF9138BC968BAD107080FE409CAEFEC258F31D7E09C32AA3244C86C399CBABCA6EB71CEC3BA464F3FAE53FD9C8CA1B0515E0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7Jv35gwMd2OGpphHXUkq6Q== X-DA7885C5: 79C45AF93D15BCB499AD014E9090B53182F44689AE9B51C0A65BABDBF643B898262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E157BAB17265B516E494A23ABDA0EFD830FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM in general, but have the same question as Sergey. On 15.08.22, Sergey Bronnikov wrote: > Igor, please see my comment below. > > On 11.08.2022 14:17, Igor Munkin wrote: > > Use out of source build configuration for LuaJIT testing jobs in all > > GitHub workflows. For this build type configuration unique subdirectory > > (using GitHub run ID) within runner temporary directory is used as a > > binary artefacts tree. > > > > Signed-off-by: Igor Munkin > > --- > > .github/actions/environment/action.yml | 5 +++++ > > .github/workflows/lint.yml | 3 ++- > > .github/workflows/linux-aarch64.yml | 6 +++++- > > .github/workflows/linux-x86_64-ninja.yml | 6 +++++- > > .github/workflows/linux-x86_64.yml | 7 ++++++- > > .github/workflows/macos-m1.yml | 6 +++++- > > .github/workflows/macos-x86_64.yml | 7 ++++++- > > 7 files changed, 34 insertions(+), 6 deletions(-) > > > > diff --git a/.github/actions/environment/action.yml b/.github/actions/environment/action.yml > > index 43323bc7..7fb2625f 100644 > > --- a/.github/actions/environment/action.yml > > +++ b/.github/actions/environment/action.yml > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > > index 8c8dcff1..21d86764 100644 > > --- a/.github/workflows/linux-aarch64.yml > > +++ b/.github/workflows/linux-aarch64.yml > > @@ -53,11 +53,15 @@ jobs: > > sudo apt -y update > > sudo apt -y install cmake gcc make perl > > - name: configure > > - run: cmake . ${{ matrix.CMAKEFLAGS }} > > + run: > > > + cmake -S . -B ${{ env.BUILDDIR }} > > + ${{ matrix.CMAKEFLAGS }} > > - name: build > > run: cmake --build . --parallel > > + working-directory: ${{ env.BUILDDIR }} > > - name: test > > run: cmake --build . --parallel --target test > > + working-directory: ${{ env.BUILDDIR }} > > 1. I don't get an idea to use current dir for CMake and specify a > working-directory in a job step. > > Why not "cmake --build ${{ env.BUILDDIR }}" as above? I don't get the idea too :). > > > > > test-tarantool-debug-w-GC64: > > name: Tarantool Debug GC64:ON > > diff --git a/.github/workflows/linux-x86_64-ninja.yml b/.github/workflows/linux-x86_64-ninja.yml > > index 2877d2f6..72d56d54 100644 > > --- a/.github/workflows/linux-x86_64-ninja.yml > > +++ b/.github/workflows/linux-x86_64-ninja.yml > > name: Tarantool Debug GC64:OFF -- Best regards, Sergey Kaplun