From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A50BD6ECE3; Thu, 30 Jun 2022 01:24:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A50BD6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656541461; bh=Ppa+hoOVTyyQPBknI6QTszsQgLDb+6+oIJVU9uZZS8Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qfL9Eqm5fn68XJ8zif4kyxtgn46D6SxMhM5aLUdM4PlfVUEB5H3OP0CIafRBL5txl 1UzVd8N/sqIEYufLYrOjTbvPirYOgBZu0WS5rTkroaOCzG6Nfc2sYNhuHBBjwS/rsV N1lk2Fwd5+HYbn8GfRoiZ6TJ2YfdcpHoObag2HaY= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B1F6F6ECE3 for ; Thu, 30 Jun 2022 01:24:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B1F6F6ECE3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1o6g6c-0005hM-Q8; Thu, 30 Jun 2022 01:24:19 +0300 Date: Thu, 30 Jun 2022 01:17:08 +0300 To: Sergey Kaplun Message-ID: References: <024281fade12f71b734aece21637ea09c11bc759.1655911291.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F05DDD76985F91268BFFB1ACD8FADBD70A64033294529D98182A05F538085040E7EB6CDB00D8F585663993785E81834574388C472E0F09CF205EDEA719B04FCC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE779AAD18609327F83EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BA974A3F996F5FBFB2F0965D16132D7D0CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006377C70927E34808485389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7350555CCFDA08FA3FAC4224003CC83647689D4C264860C145E X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C6BD3392006AE91BDECED16F72989BB6C4952BA26F7C93968AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340EEB18E49183157181C8CFA25DAB89E8F2191F7E0A5FCFFA0EE6D6D60CE198781F1230227AFB4BBD1D7E09C32AA3244CEEEFFFF59BECAC84E07A3BFCD0C27CCE3C6EB905E3A8056B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhvrbUd41KJnRaOxg1Uid+g== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E7615622E10E6FC2426D117CB2BC29892A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! See my comments inline and the changes on the remote branch[1]. On 23.06.22, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a few nits regarding the commit message. Added your tag: | Reviewed-by: Sergey Kaplun > > On 22.06.22, Igor Munkin wrote: > > In scope of the commit 4195eb8f7e2abcf75f92eedd2859b7991cc8b363 ("ci: > > Typo: s/In scope/In the scope/ I strongly doubt. Ignoring. > > > make GitHub workflows more CMake-ish") --parallel value has been > > explicitly set to $(nproc) + 1, since -j default behaviour differs for > > Ninja and GnuMake. However, MacOS lacks nproc command, but CI silently > > continues to execute pipeline. > > Typo: s/pipeline/the pipeline/ Fixed. > > > > > This patch fixed MacOS-specific workflows changing nproc command with > > Nit: s/fixed/fixes/ as far as we prefer Present Simple for commits > description. > Feel free to ignore. You're right, thanks! Fixed. > > > sysctl -n hw.ncpu. > > > > Signed-off-by: Igor Munkin > > --- > > > > > -- > > 2.34.0 > > > > -- > Best regards, > Sergey Kaplun [1]: https://github.com/tarantool/luajit/commit/fe2df4c -- Best regards, IM