From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 119EF6ECE3; Tue, 28 Jun 2022 18:48:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 119EF6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656431310; bh=NVJeTdXv60ZO4ZjPZZpTJ9BLzdng2pSjmdo9678Yj1Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZLXPvyxWjWMVCSPzjRMrxUSWA/UU537jkPtdwkXjYliRvBKKWIXH24LRq3Cr/DKG6 iod3N5SYcmX2E8sEz51cl2gDuPFCjccxaMWZXOhbbHumzKXY7bBSkZPiw3WypBHk+U tEr4lHToJLi0q3z8Hcmg3FyijW9nPvtACnzbH2Dw= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4352E6ECE3 for ; Tue, 28 Jun 2022 18:48:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4352E6ECE3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1o6DS0-0006nM-9o; Tue, 28 Jun 2022 18:48:28 +0300 Date: Tue, 28 Jun 2022 18:41:18 +0300 To: Sergey Kaplun Message-ID: References: <0d207e1a15360109e1e9c4bb775248f0fc04edc6.1631170629.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0d207e1a15360109e1e9c4bb775248f0fc04edc6.1631170629.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD921FF253C2DCA64328D82274A16F3B1206881FAF42C11B61F00894C459B0CD1B98D66C4E63A0FABC5415E2A20E6C181F8FC3B6EEE366DC70D3A387867F39FB055 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE92FB8C11ED3D88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ED49BDD9D63AA0CDA5E0FCBEB33E7C44117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B049C5FA07E1E73E1A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CB1724D34C644744043847C11F186F3C59DAA53EE0834AAEE X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A59188148EC1D2C3990A5DD0A286B47D9CADE16B7F33A0A66DD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA13E2DDB9067862D0EF9D0DE0A22E3F65BDF9E8504C5A477342D4367C23A13CFBA1EA0646F0AB971D7E09C32AA3244CE77F0ABC9F8F20DF4F0DED2A8F2203E3C3B3ADDA61883BB5927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojX1xomQseBkVJWPVqxrSO5A== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E002B047C1E4D9C1106F677FB07B0FE75A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: fix path storage for non-concatable objects X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, as trivial. I've only made some tweaks in commit message: | test: fix path storage for non-concatable objects | | When a key of the table to be compared via `tap.test:is_deeply()` is a | non-concatable object (i.e. lightuserdata) its concatenation with the | path prefix raises an error. As a result of this patch the object is | explicitly converted to string to avoid this error. -- Best regards, IM