From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E53916ECE3; Thu, 23 Jun 2022 19:26:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E53916ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656001580; bh=o/8yF+55/SEuk6Ht5UfseNDE4HBVOzsvUO1fojU6XD4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x7kKJVYgd/EbrnFqz4a8/gIRSVHg5aJVlR5WV/NiBml2c3oAiK0WxZWMyF2tn6uck ZNYDqOGQD6zL+TrkelAzj6MSSwHU3Wr0O1THOvZ4UJAxh/lkk3aWpLByuJRIzlmFtq FYUj+SWBZanMAI401dRgRN4WptzR08izqYfQhQCI= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 01E186ECE3 for ; Thu, 23 Jun 2022 19:26:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 01E186ECE3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1o4Per-00076O-6K; Thu, 23 Jun 2022 19:26:17 +0300 Date: Thu, 23 Jun 2022 19:19:08 +0300 To: Sergey Kaplun Message-ID: References: <20211227102524.9410-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211227102524.9410-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9EAB0F1B3E0C6ABD3189E81084241ECA83B361FE07F977639182A05F538085040D68ED4518BADD19F73A9E1944F3B942E89AA21D7D5AC910DA263203ACB8673BA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72AC9FB60380F23AEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063771C846A5973DEE7E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86F13617055BFECA96DB4F982AB8D7157117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142181A7CDF0E2BD6CD9B9A1086360978C81BC0EF495FBE7C0D47F3880CF67C5AD8C09C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3457FA942CB4462B4CFF228A90C777920DC8B03C32AC70C7A1A4ECB45F513D771DFB30B0F4EE31E8DA1D7E09C32AA3244CFA445975786F2F830ADA09EBFE58D97755E75C8D0ED9F6EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0at9oz1ZZJ8DmBd7pnAFog== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E340DC2EB125951892262C70CA9F59A16A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Add stricter check for print() vs. tostring() shortcut. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! In addition to Sergos' nits regarding the commit message, I have two regarding the test: 1. Why didn't you use helper for your purposes? It fits better than the pack of hacks implementing quite a similar routine. 2. Test name should start with the corresponding issue number from LuaJIT queue, AFAIR. I fixed both comments within fixup commit on top of your branch[1]. Otherwise the patch LGTM, so if you're OK with the changes, I'll proceed with it. Last, but not least: I see no ChangeLog entry in the patch. Could you please drop a few words regarding the change in this thread? [1]: https://github.com/tarantool/luajit/commit/da9f089 -- Best regards, IM