From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5DB246ECE3; Thu, 23 Jun 2022 11:47:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5DB246ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655974068; bh=tkqOMfX2QMVl/jxrHGzlM9KkwiP48B2GkrqjnKqJfiU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W0jdmKMsP9U8jJNdIvEy36kVRPIltmkouY882BqIPgvHvE01faBoe1/9euL2m8/kr gyu9OwtctbSGn4pT/8Fbmiie0LwHe0YKETeRVanRXM0+2bz1NazGHqicqMSe+Bm/lr aDcTcb7cGZ99iY6RCVKW4BesaJz9Ypv+Q6zyUebM= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 61AF56ECE3 for ; Thu, 23 Jun 2022 11:47:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61AF56ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o4IV7-0006aS-In; Thu, 23 Jun 2022 11:47:45 +0300 Date: Thu, 23 Jun 2022 11:45:26 +0300 To: Igor Munkin Message-ID: References: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9344F665CF1C84C2918087179936BF9E5D8EDAEF694F00F9F182A05F538085040EAB0BE9559D15BDB37D008A37A975D21D4F17044ED0822B21E700233B03D58B4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79683A3C835791080EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B3FBAE160100E6228638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815CCB545A7A9C912800FDD2EAE0A33E5117882F44604297287769387670735209ECD01F8117BC8BEA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CFA80D66F452D417A43847C11F186F3C59DAA53EE0834AAEE X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218BDB97F43142B77587866D6147AF826D815CCB545A7A9C912800FDD2EAE0A33E5F972CCD2F8FE1EF1CFC4036BBF6A4EA9B11811A4A51E3B0915E2725BA614EAEA1EF972C1F679AE1C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34324A9840C798D500277AEFA94B112643F3C94163C95A2D3CD0DCB9CB67A178EE33A6105492159F351D7E09C32AA3244C114E91E58507259CC85A64D59A07625C4DBEAD0ED6C55A80FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9/HGj9wIviMA6ZpyZuLepQ== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E9D021CBB88B6142990BD19C97C3763A00FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! Nice to see our CI improving! Please consider my comments below. On 22.06.22, Igor Munkin wrote: > This patch introduces additional steps with Tarantool integration > testing to all existing LuaJIT workflows. All steps invoke reusable > workflow[1] from Tarantool repository for each matrix entry being set > for particular LuaJIT workflow. AFAICS, there are no workflows for different OS like Fedora, FreeBSD, etc.. Same for integration testing workflow for Tarantool itself, plus workflows with different compilers (gcc/clang). Should developer still bump LuaJIT in Tarantool repo and create PR to test full Tarantool CI? > > [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml > > Signed-off-by: Igor Munkin > --- > .github/workflows/linux-aarch64.yml | 25 +++++++++++++++-- > .github/workflows/linux-x86_64.yml | 43 +++++++++++++++++++++++++++-- > .github/workflows/macos-m1.yml | 25 +++++++++++++++-- > .github/workflows/macos-x86_64.yml | 43 +++++++++++++++++++++++++++-- > 4 files changed, 124 insertions(+), 12 deletions(-) > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > index de360b12..293b572e 100644 > --- a/.github/workflows/linux-aarch64.yml > +++ b/.github/workflows/linux-aarch64.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (Linux/aarch64)" > +name: "Linux/aarch64 test workflow" > > on: > push: > @@ -29,7 +29,7 @@ concurrency: > cancel-in-progress: true > > jobs: > - test-linux-aarch64: > + test-luajit: > runs-on: graviton > strategy: > fail-fast: false > @@ -40,7 +40,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:ON > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:ON > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -56,3 +56,22 @@ jobs: > run: cmake --build . --parallel $(($(nproc) + 1)) > - name: test > run: cmake --build . --parallel $(($(nproc) + 1)) --target test > + > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master I suggest to set one variable for this to reduce copy-paste. Also, why do you prefer copy workflows instead matrix usage? The only thing changes here -- buildtype. > + with: > + GC64: ON > + buildtype: Debug > + host: graviton > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: graviton > + revision: ${{ github.sha }} > diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux-x86_64.yml > index d6434afe..3eaf436d 100644 > --- a/.github/workflows/linux-x86_64.yml > +++ b/.github/workflows/linux-x86_64.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (Linux/x86_64)" > +name: "Linux/x86_64 test workflow" > > on: > push: > @@ -29,7 +29,7 @@ concurrency: > cancel-in-progress: true > > jobs: > - test-linux-x86_64: > + test-luajit: > runs-on: ubuntu-20.04-self-hosted > strategy: > fail-fast: false > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: Linux/x86_64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -57,3 +57,40 @@ jobs: > run: cmake --build . --parallel $(($(nproc) + 1)) > - name: test > run: cmake --build . --parallel $(($(nproc) + 1)) --target test > + > + test-tarantool-debug-wo-GC64: > + name: Tarantool Debug GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF Same question here, but also with GC64 mode. > + buildtype: Debug > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: Debug > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-release-wo-GC64: > + name: Tarantool Release GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF > + buildtype: RelWithDebInfo > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > index a38f70f7..d305e609 100644 > --- a/.github/workflows/macos-m1.yml > +++ b/.github/workflows/macos-m1.yml as far as it is kinda the same. > diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml > index a7c2f4e3..fc28c683 100644 > --- a/.github/workflows/macos-x86_64.yml > +++ b/.github/workflows/macos-x86_64.yml as far as it is kinda the same. > -- > 2.34.0 > -- Best regards, Sergey Kaplun