From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 820BF6ECE3; Thu, 23 Jun 2022 11:21:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 820BF6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655972490; bh=+//VP0carK3L3bHDT3L29Fo0fddRFRa4JbXrOngCtX4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RoqsaoaObid/XdlK+x838Zz6QbRnEUhShpQqllbMXJJuKBiBH7SMT/RrtGP8LneUK NLKhs8xpDJROWzGVUK/8Ac8LFg7orSd9oKG5C7Tj0RM2d28ltzuXfJacWMY1zixsz+ oD0quoWkm/28ntrbWG4wv8AX5jYhga1I+KKsoOHA= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4AFE66ECE3 for ; Thu, 23 Jun 2022 11:21:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4AFE66ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o4I5c-0003Ql-HL; Thu, 23 Jun 2022 11:21:24 +0300 Date: Thu, 23 Jun 2022 11:19:05 +0300 To: Igor Munkin Message-ID: References: <024281fade12f71b734aece21637ea09c11bc759.1655911291.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <024281fade12f71b734aece21637ea09c11bc759.1655911291.git.imun@tarantool.org> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9344F665CF1C84C292AD00F54ED34F0E5EDC499DA1A5C11C5182A05F538085040A83016C988E2CA28023434D94B05D9519C9C963D4407429574ACEA981D255332 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372D850D7477D401F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DF4724336318E92530FE3A442969634C117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218DF4CD06DEF521B767866D6147AF826D8DF4724336318E92530FE3A442969634CF972CCD2F8FE1EF1CFC4036BBF6A4EA9B11811A4A51E3B0915E2725BA614EAEA1EF972C1F679AE1C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3490011A262ADAEDFEBE40EA0FCA31531390CAA97FFF87AC9890E5BAF8CC017759992C1F7FAC3703081D7E09C32AA3244C6361ECE57748DB256EC3C78583107D3224AF4FAF06DA24FDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9/HGj9wIviNGnDg73rZF1g== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EDD64806E671B11C4D738C43E8923544B0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 22.06.22, Igor Munkin wrote: > In scope of the commit 4195eb8f7e2abcf75f92eedd2859b7991cc8b363 ("ci: Typo: s/In scope/In the scope/ > make GitHub workflows more CMake-ish") --parallel value has been > explicitly set to $(nproc) + 1, since -j default behaviour differs for > Ninja and GnuMake. However, MacOS lacks nproc command, but CI silently > continues to execute pipeline. Typo: s/pipeline/the pipeline/ > > This patch fixed MacOS-specific workflows changing nproc command with Nit: s/fixed/fixes/ as far as we prefer Present Simple for commits description. Feel free to ignore. > sysctl -n hw.ncpu. > > Signed-off-by: Igor Munkin > --- > -- > 2.34.0 > -- Best regards, Sergey Kaplun