From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 110856ECE3; Wed, 22 Jun 2022 11:26:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 110856ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655886413; bh=XIXpgII/3aB/h0GKfcGjd4EKM67T7Gr6kXIHh0cN1Xk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LTCfZnsBXg0fLKHaPnxZXvs+NHfQOj7x5lOlfymVv/i4bHO2lnsHkf+Wwu6sncwD0 4TvKQNhUAAgC6VEHlii5y0z/+Oj4A4Fxq5dPHK+vsUldCSOIpxbhh+nVd5mYyavd8V p5xVjOV4sNShvhKdL42IvTlhvFjgY2mW2sN9U0jg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA5F06ECE3 for ; Wed, 22 Jun 2022 11:26:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA5F06ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o3vhK-0005qW-Pe; Wed, 22 Jun 2022 11:26:51 +0300 Date: Wed, 22 Jun 2022 11:24:31 +0300 To: sergos Message-ID: References: <20211230114513.23020-1-skaplun@tarantool.org> <4E9E5823-C595-4F01-AA26-62D2BEA2DA28@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4E9E5823-C595-4F01-AA26-62D2BEA2DA28@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD947AAA3FEFDE5AEDDA1161F364DE8888599D74C92715952BC182A05F5380850400C02256C3057CF6AA7C870F2636A44556ED4042CF5154DA45509A5DC9C6BB36A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B4D64F1449264784EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063721BEEAF38C6AE0B78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EF43AAA8F724F87A6695B770EB9EBD45117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218AE33ED66789AAD917866D6147AF826D8EF43AAA8F724F87A6695B770EB9EBD45F972CCD2F8FE1EF1CFC4036BBF6A4EA9B11811A4A51E3B0915E2725BA614EAEA1EF972C1F679AE1C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F3735C80F9F4B96DFBABE2EE0F28C7A4A76A2FF7E9EF7D69265718A8DD1393D84DC2012D795FCEF81D7E09C32AA3244C8DE191870ED38642BBBF597A294BFB41A995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+ZQCdndr4Hk07Le7YwcS1g== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EE82C0CB1174FD2E67D47E239BEAF36510FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix debug.debug() for non-string errors. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 21.06.22, sergos wrote: > Hi! > > Thanks for the patch! > > It’s strange, but Tarantool happens to handle this case correctly? Not for me:). | $ echo 'error({}); print(42)' | ./src/tarantool -e 'debug.debug()' | lua_debug> Segmentation fault | ... | #5 0x55a6323a6b84 in lj_cf_debug_debug+ef | #6 0x55a63236b66f in lj_BC_FUNCC+34 | #7 0x55a63237687b in lua_pcall+379 | #8 0x55a632305317 in luaT_call+29 | #9 0x55a6322fd8b7 in run_script_f+427 | #10 0x55a6320f496e in _ZL16fiber_cxx_invokePFiP13__va_list_tagES0_+1e | #11 0x55a63232b3f0 in fiber_loop+8d | #12 0x55a632686716 in coro_init+4c May be you should build it with debug? | $ src/tarantool -v | Tarantool 2.10.0-beta2-6-g634f59c7f | Target: Linux-x86_64-Debug | Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_BACKTRACE=ON P.S. I use not the latest Tarantool as far as there is no related patches (AFAIK). > > % echo 'error({}); print(42)' | ./src/tarantool -e 'debug.debug()' > lua_debug> (null) > lua_debug> % % echo $? > 0 > > Surely, with the patch applied I see the following, as expected: > > % echo 'error({}); print(42)' | ./src/tarantool -e 'debug.debug()' > lua_debug> (error object is not a string) > lua_debug> % % > > > Is it relevant at all? > > regards, > Sergos > > > > On 30 Dec 2021, at 14:45, Sergey Kaplun wrote: > > > -- Best regards, Sergey Kaplun