From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 45DC66FC83; Thu, 30 Jun 2022 15:22:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 45DC66FC83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656591743; bh=mC830DQPsruuj7jz9rnLULhIyXgKK+gmDPVZYlgN0ok=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lMErFQ4lhbwea7BAZWMRE3yv9oq4/59G8DkgPZPbckhDzqrONIzvMBuv0CZkrO8eE KrJMbXmkwVkNjx1GmKEQ3MnWoHl6Tx1ZA+ndNR4LwJZSDOIpU+QN0PUmAUQproQH++ dVIkgNw4gES4SGk9FnzFJZgsnIa3R/njAPG/kE18= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0EAE96DB12 for ; Thu, 30 Jun 2022 15:18:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EAE96DB12 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1o6t7t-00067b-6R; Thu, 30 Jun 2022 15:18:29 +0300 Date: Thu, 30 Jun 2022 15:11:18 +0300 To: Sergey Kaplun Message-ID: References: <20211027130222.15625-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211027130222.15625-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F05DDD76985F9126692D3D1FA89E748E12FC702E1748058B182A05F53808504042F732FD106A1754A8E45545D4EC3553B45F958FC9730D146D2D08A40ED5735A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637188F5654332B449D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D827174F8D6FA148288351A860EEADE890117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF80095D1E57F4578A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C837C4FEFBD186071C4224003CC83647689D4C264860C145E X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C63EBED25B40ECB4C44D96830331FA1485B03B76D19BDC651AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34987A0E8D235BB534EBCD89243C7B38AF1C86EC90224AF087CE5FF9BCD025D7906EC74C2C39021F341D7E09C32AA3244CF90E6423D9DE13415C6180ACB975CFECA95CA90A1D8AC565927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhvrbUd41KJnDPjc/DlS93g== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E99A3EF311BAAABB354E3ACA7CF9E9A50A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix assembly of HREFK. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patch into all long-term branches with ARM64 support in tarantool/luajit and bumped a new version in master, 2.10. On 27.10.21, Sergey Kaplun wrote: > From: Mike Pall > > Reported by Jason Teplitz. > > (cherry picked from commit 06cd9fce7df440323647174f1ca4a01281ec8acd) > > LDR instruction with register offset [1] has a restriction, that the > destination register must be different from the register used for offset > base. HREFK IR emits LDR instruction for a load of node key to a > register. Base register to offset contains a node address. The register > holding the node address is not excluded from a allow set, when loading > the key value to a new register, and may be chosen by the register > allocator as a destination for the key value, which violates the > aforementioned restriction. > > This patch excludes the node register from the allowing set in the > allocation of register for a key value. > > Sergey Kaplun: > * added the description and the test for the problem > > [1]: https://developer.arm.com/documentation/dui0489/c/arm-and-thumb-instructions/memory-access-instructions/ldr-and-str--register-offset- > > Part of tarantool/tarantool#6548 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-357-arm64-hrefk > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-357-arm64-hrefk > LuaJIT issue: https://github.com/LuaJIT/LuaJIT/issues/357 > Issue: https://github.com/tarantool/tarantool/issues/6548 > > src/lj_asm_arm64.h | 11 ++++---- > .../lj-357-arm64-hrefk.test.lua | 27 +++++++++++++++++++ > 2 files changed, 32 insertions(+), 6 deletions(-) > create mode 100644 test/tarantool-tests/lj-357-arm64-hrefk.test.lua > > -- > 2.31.0 > -- Best regards, IM