From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATH luajit] GC64: fix 64-bit constant fusion
Date: Thu, 30 Jun 2022 15:10:59 +0300 [thread overview]
Message-ID: <Yr2S07Fi2CcAwNTe@tarantool.org> (raw)
In-Reply-To: <804A99A3-6D0C-4DA9-A939-26FFED0EC823@tarantool.org>
Sergos,
I've checked the patch into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.
On 28.05.21, Sergey Ostanevich wrote:
> Author: Mike Pall <mike>
> Date: Mon Aug 28 10:43:37 2017 +0200
>
> x64/LJ_GC64: Fix fallback case of asm_fuseloadk64().
>
> Contributed by Peter Cawley.
>
> (cherry picked from commit 6b0824852677cc12570c20a3211fbfe0e4f0ce14)
>
> Code generation under LJ_GC64 missed an update to the mcode area after
> a 64bit constant encoding. This lead to a corruption to the constant
> later on.
> The problem is rather rare, since there should be big enough (4GiB)
> distance from the currently allocated mcode to the dispatch pointer.
> This lead to a number of flaky tests, trackers are addressed.
>
> Sergey Ostanevich:
> * added the description and the test for the problem
>
> Closes: #4095, #4199, #4614
>
> Signed-off-by: Sergey Ostanevich <sergos@tarantool.org>
>
<snipped>
--
Best regards,
IM
prev parent reply other threads:[~2022-06-30 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 12:06 Sergey Ostanevich via Tarantool-patches
2021-07-04 21:06 ` Igor Munkin via Tarantool-patches
2022-02-16 15:44 ` Sergey Kaplun via Tarantool-patches
2022-06-21 12:11 ` sergos via Tarantool-patches
2022-06-22 13:32 ` Sergey Kaplun via Tarantool-patches
2022-06-29 8:04 ` Igor Munkin via Tarantool-patches
2022-06-30 12:10 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr2S07Fi2CcAwNTe@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergos@tarantool.org \
--subject='Re: [Tarantool-patches] [PATH luajit] GC64: fix 64-bit constant fusion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox